From: "Jon Smirl" <jonsmirl@gmail.com>
To: "Jean Delvare" <khali@linux-fr.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] of: i2c: improve last resort compatible entry selection
Date: Tue, 15 Jul 2008 09:40:08 -0400 [thread overview]
Message-ID: <9e4733910807150640x52cca982jf4f1ccfe7fd506cf@mail.gmail.com> (raw)
In-Reply-To: <487C7F9A.7030201@scram.de>
On 7/15/08, Jochen Friedrich <jochen@scram.de> wrote:
> Hi Anton,
>
>
> > Since no sane driver will ever match specific devices, what we want is
> > to select most generic option (last). Then driver may call
> > of_device_is_compatible() if it is really interested in details.
>
>
> My original intention was to have alias entries for specific devices in the
> i2c device drivers. Later, Jean decided to only have the most generic names
> in there (like in http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=drivers/media/video/tvaudio.c;h=c77914d99d15c5972c94e9763a08b5789098e90a;hp=6f9945b04e1f2bcd676f0ed8dc910994b29ed300;hb=ae429083efe996ca2c569c44fd6fea440676dc33;hpb=60b129d7bfa3e20450816983bd52c49bb0bc1c21)
> So your patch is correct.
Why aren't we listing the chip names in the driver's id section? Large
chip id tables are not unusual in the kernel, the e1000 driver has
about 70 entries.
Taking the chip id table out of the driver just means we have to build
it somewhere else. It doesn't save space, the tables just get moved.
Device firmware has the chip names in it so there has to be code in
the kernel somewhere to do the mapping from chip id to linux driver
name.
Pushing the linux driver name down into the firmware is even crazier.
+ /* 2. search for linux,<i2c-type> entry */
Now if the linux driver gets renamed everyone on the planet needs a
firmware update.
--
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2008-07-15 13:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 17:54 [PATCH] of: i2c: improve last resort compatible entry selection Anton Vorontsov
2008-07-15 10:44 ` Jochen Friedrich
2008-07-15 13:40 ` Jon Smirl [this message]
2008-07-15 14:05 ` Jean Delvare
2008-07-15 14:52 ` Jochen Friedrich
2008-07-15 15:39 ` Jean Delvare
2008-07-27 0:11 ` Grant Likely
2008-07-27 5:05 ` Jon Smirl
2008-07-27 5:35 ` Grant Likely
2008-07-27 14:21 ` Jon Smirl
2008-07-27 21:52 ` Segher Boessenkool
2008-07-27 22:00 ` Jon Smirl
2008-07-28 4:16 ` M. Warner Losh
2008-07-28 7:47 ` Segher Boessenkool
2008-07-30 14:42 ` Grant Likely
2008-07-30 20:20 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910807150640x52cca982jf4f1ccfe7fd506cf@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=khali@linux-fr.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).