Re: netif_schedule and mpc5200_fec

["Jon Smirl" <jonsmirl@gmail.com>]

On 7/22/08, David Miller <davem@davemloft.net> wrote:
> From: "Jon Smirl" <jonsmirl@gmail.com>
>
> Date: Tue, 22 Jul 2008 18:54:18 -0400
>
>
>  > On 7/22/08, David Miller <davem@davemloft.net> wrote:
>  > > From: "Jon Smirl" <jonsmirl@gmail.com>
>  > >  Date: Tue, 22 Jul 2008 17:03:32 -0400
>  > >
>  > >
>  > > > On 7/22/08, Jon Smirl <jonsmirl@gmail.com> wrote:
>  > >  > > I just updated to linus/master and mpc5200_fec won't boot.
>  > >  >
>  > >  > It does boot, but this badness looks like it is coming from this
>  > >  > patch. I don't know enough about networking to debug it.
>  > >
>  > >
>  > > I just applied the following patch from Anton Vorontsov which
>  > >  will fix this.
>  >
>  > I applied this piece and still have the same error.
>
>
> There are no calls to functions in mpc52xx_fec_adjust_link that
>  can lead to __netif_schedule() any more.
>
>  Therefore I can't see how your backtrace is even possible.
>
>  Please double check that you've really applied the patch
>  and that mpc52xx_fec_adjust_link lacks any calls to
>  netif_*_queue() and *netif_schedule().

You're right. That patch fixes it. Another thing I brought down made
my image file not get generated and I was using an old image.


>
>  Thanks.
>


-- 
Jon Smirl
jonsmirl@gmail.com