From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <9e4733910807221633x4385c36dod81ac3f81e242e5c@mail.gmail.com> Date: Tue, 22 Jul 2008 19:33:13 -0400 From: "Jon Smirl" To: "David Miller" Subject: Re: netif_schedule and mpc5200_fec In-Reply-To: <20080722.160718.122532549.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <9e4733910807221403g512f6e37s6722c7950f881224@mail.gmail.com> <20080722.154201.234654750.davem@davemloft.net> <9e4733910807221554j451019a0sa711541e97fbf0aa@mail.gmail.com> <20080722.160718.122532549.davem@davemloft.net> Cc: davem@redhat.com, Linuxppc-dev@ozlabs.org, netdev@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 7/22/08, David Miller wrote: > From: "Jon Smirl" > > Date: Tue, 22 Jul 2008 18:54:18 -0400 > > > > On 7/22/08, David Miller wrote: > > > From: "Jon Smirl" > > > Date: Tue, 22 Jul 2008 17:03:32 -0400 > > > > > > > > > > On 7/22/08, Jon Smirl wrote: > > > > > I just updated to linus/master and mpc5200_fec won't boot. > > > > > > > > It does boot, but this badness looks like it is coming from this > > > > patch. I don't know enough about networking to debug it. > > > > > > > > > I just applied the following patch from Anton Vorontsov which > > > will fix this. > > > > I applied this piece and still have the same error. > > > There are no calls to functions in mpc52xx_fec_adjust_link that > can lead to __netif_schedule() any more. > > Therefore I can't see how your backtrace is even possible. > > Please double check that you've really applied the patch > and that mpc52xx_fec_adjust_link lacks any calls to > netif_*_queue() and *netif_schedule(). You're right. That patch fixes it. Another thing I brought down made my image file not get generated and I was using an old image. > > Thanks. > -- Jon Smirl jonsmirl@gmail.com