From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.28]) by ozlabs.org (Postfix) with ESMTP id B31B8DE310 for ; Thu, 24 Jul 2008 01:16:19 +1000 (EST) Received: by yx-out-2324.google.com with SMTP id 8so496956yxg.39 for ; Wed, 23 Jul 2008 08:16:17 -0700 (PDT) Message-ID: <9e4733910807230816m474af04ch9b6650cdbb96ffec@mail.gmail.com> Date: Wed, 23 Jul 2008 11:16:17 -0400 From: "Jon Smirl" To: "Jon Smirl" , linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org, "Grant Likely" Subject: Re: [alsa-devel] [PATCH 2/2] Allow a custom ASOC machine driver with soc-of-simple In-Reply-To: <20080723151431.GA22926@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20080722235349.11648.90112.stgit@terra> <20080722235351.11648.56387.stgit@terra> <20080723105334.GC8377@sirena.org.uk> <9e4733910807230709l4249eaf6m750bad811342ba13@mail.gmail.com> <20080723151431.GA22926@sirena.org.uk> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 7/23/08, Mark Brown wrote: > On Wed, Jul 23, 2008 at 10:09:01AM -0400, Jon Smirl wrote: > > On 7/23/08, Mark Brown wrote: > > > > > ...this doesn't just allow a custom machine driver, it requires that > > > something configures at least the machine name. That's not a problem > > > from the ASoC point of view but possibly from the PowerPC side? > > > You have to configure at least the name. Otherwise if the machine > > driver is the last to register, how do you know to hold off the final > > registration and wait for the machine driver to appear? > > > I understand why you have made this change but it's a substantial change > which should at least be documented in the changelog (I'd expect to see > some mention of how this is supposed to be configured, for example). > I'd also expect something to handle the existing user. This is a modification to Grant's new driver. Grant is the only other user. > > Like I said, I'm not entirely sure that you're supposed to be using this > driver if you want a machine driver: this is a machine driver and I'm > not sure if it's supposed to cover all cases or not. Grant? > > > > Or is it ok for me to change these after the platform device has been created? > > of_soc->dai_link.ops = machine_ops; > > of_soc->machine.name = machine_name; > > > No. > -- Jon Smirl jonsmirl@gmail.com