From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jonsmirl@gmail.com>
Message-ID: <9e4733910807251546k2388b1afgba52081c20332dc4@mail.gmail.com>
Date: Fri, 25 Jul 2008 18:46:38 -0400
From: "Jon Smirl" <jonsmirl@gmail.com>
To: benh@kernel.crashing.org
Subject: Re: can't boot mpc5200, powerpc: Enable AT_BASE_PLATFORM aux vector
In-Reply-To: <1217024108.11188.117.camel@pasglop>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
References: <9e4733910807251451s623b87cetcf7ed5ff6a12f012@mail.gmail.com>
	<20080725220038.GI9594@localdomain>
	<1217024108.11188.117.camel@pasglop>
Cc: ppc-dev <Linuxppc-dev@ozlabs.org>, Nathan Lynch <ntl@pobox.com>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On 7/25/08, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Fri, 2008-07-25 at 17:00 -0500, Nathan Lynch wrote:
>  > Jon Smirl wrote:
>  > > I've lost my ability to boot on the mpc5200. Reverting this patch fixes it.
>  >
>  > How does it fail?
>  >
>  >
>  > > @@ -1652,6 +1655,14 @@ struct cpu_spec * __init identify_cpu(unsigned
>  > > long offset, unsigned int pvr)
>  > >                     } else
>  > >                             *t = *s;
>  > >                     *PTRRELOC(&cur_cpu_spec) = &the_cpu_spec;
>  > > +
>  > > +                   /*
>  > > +                    * Set the base platform string once; assumes
>  > > +                    * we're called with real pvr first.
>  > > +                    */
>  > > +                   if (powerpc_base_platform == NULL)
>  > > +                           powerpc_base_platform = t->platform;
>  > > +
>  >
>  > Hmm, maybe this needs RELOC/PTRRELOC tricks?
>
>
> Hrm... indeed.
>
>  if (RELOC(powerpc_base_platform))
>         RELOC(powerpc_base_platform) = t->platform;

It completely fails booting, no console or anything.

Where is RELOC defined, prom_init.c?

#ifdef CONFIG_PPC64
#define RELOC(x)        (*PTRRELOC(&(x)))
#define ADDR(x)         (u32) add_reloc_offset((unsigned long)(x))
#define OF_WORKAROUNDS  0
#else
#define RELOC(x)        (x)
#define ADDR(x)         (u32) (x)
#define OF_WORKAROUNDS  of_workarounds
int of_workarounds;
#endif



>
>  try that.
>
>  Ben.
>
>
>


-- 
Jon Smirl
jonsmirl@gmail.com