From: "Jon Smirl" <jonsmirl@gmail.com>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling
Date: Tue, 19 Aug 2008 17:23:40 -0400 [thread overview]
Message-ID: <9e4733910808191423u34946955lc85caa6b2217b390@mail.gmail.com> (raw)
In-Reply-To: <20080819212937.01dfd024@lxorguk.ukuu.org.uk>
On 8/19/08, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > Shouldn't this be
> >
> > > - if (client->irq <= NO_IRQ)
> >
> > instead of
>
>
> NO_IRQ is obsolete. client->irq != is the test and IRQ numbers are
> unsigned.
I don't know the status of these platforms....
asm-blackfin/irq.h:#define NO_IRQ ((unsigned int)(-1))
asm-mn10300/irq.h:#define NO_IRQ INT_MAX
asm-parisc/irq.h:#define NO_IRQ (-1)
--
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2008-08-19 21:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 16:17 [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling Anton Vorontsov
2008-08-19 20:01 ` Peter Korsgaard
2008-08-19 20:39 ` Jon Smirl
2008-08-19 20:29 ` Alan Cox
2008-08-19 21:23 ` Jon Smirl [this message]
2008-08-19 22:04 ` Alan Cox
2008-08-19 21:12 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910808191423u34946955lc85caa6b2217b390@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).