From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <9e4733910809211634u5b37e297pe8503f08de4f19a8@mail.gmail.com> Date: Sun, 21 Sep 2008 19:34:37 -0400 From: "Jon Smirl" To: "Sergei Shtylyov" Subject: Re: solution to printk() blocking interrupts? In-Reply-To: <48D6C8F0.4060808@ru.mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <9e4733910809211353k1f06fb5bi219c124d0c44b47a@mail.gmail.com> <9e4733910809211443l5638887aw856377d39fcca85c@mail.gmail.com> <48D6C8F0.4060808@ru.mvista.com> Cc: linuxppc-dev List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Sep 21, 2008 at 6:21 PM, Sergei Shtylyov wrote: > Implementing the poll_controller() method in the network driver is usually > staightforward. Good tip, the simple implementation worked. What controls this? "carrier detect appears untrustworthy, waiting 4 seconds" Get that fixed and this patch could be useful, root@phyCORE-MPC5200B-tiny:~ dmesg | grep netconsole Kernel command line: console=ttyPSC0,115200 rw debug root=/dev/nfs ip=dhcp nfsroot=192.168.1.4:/home/OSELAS.BSP-Phytec-phyCORE-MPC5200B-tiny-6/root,v3,tcp netconsole=6666@192.168.1.11/eth0,514@192.168.1.4/00:19:d1:e4:0f:8d netconsole: local port 6666 netconsole: local IP 192.168.1.11 netconsole: interface eth0 netconsole: remote port 514 netconsole: remote IP 192.168.1.4 netconsole: remote ethernet address 00:19:d1:e4:0f:8d netconsole: device eth0 not up yet, forcing it netconsole: carrier detect appears untrustworthy, waiting 4 seconds netconsole: network logging started root@phyCORE-MPC5200B-tiny:~ diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c index 4e4f683..72541b5 100644 --- a/drivers/net/fec_mpc52xx.c +++ b/drivers/net/fec_mpc52xx.c @@ -401,6 +401,16 @@ static int mpc52xx_fec_hard_start_xmit(struct sk_buff *skb, struct net_device *d return 0; } +#ifdef CONFIG_NET_POLL_CONTROLLER +static void mpc52xx_fec_poll_controller(struct net_device *dev) +{ + disable_irq(dev->irq); + mpc52xx_fec_tx_interrupt(dev->irq, dev); + enable_irq(dev->irq); +} +#endif + + /* This handles BestComm transmit task interrupts */ static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id) @@ -926,6 +936,9 @@ mpc52xx_fec_probe(struct of_device *op, const struct of_device_id *match) ndev->tx_timeout = mpc52xx_fec_tx_timeout; ndev->watchdog_timeo = FEC_WATCHDOG_TIMEOUT; ndev->base_addr = mem.start; +#ifdef CONFIG_NET_POLL_CONTROLLER + ndev->poll_controller = mpc52xx_fec_poll_controller; +#endif priv->t_irq = priv->r_irq = ndev->irq = NO_IRQ; /* IRQ are free for now */ -- Jon Smirl jonsmirl@gmail.com