* [PATCH] Format string bug in drivers/of/of_i2c.c
@ 2008-10-20 12:13 Jon Smirl
2008-10-21 2:52 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Jon Smirl @ 2008-10-20 12:13 UTC (permalink / raw)
To: linuxppc-dev
Format string bug. Not exploitable, as this is only writable by root,
but worth fixing all the same.
See 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b
---
drivers/of/of_i2c.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
index 6a98dc8..24bbef7 100644
--- a/drivers/of/of_i2c.c
+++ b/drivers/of/of_i2c.c
@@ -41,7 +41,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
info.addr = *addr;
- request_module(info.type);
+ request_module("%s", info.type);
result = i2c_new_device(adap, &info);
if (result == NULL) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Format string bug in drivers/of/of_i2c.c
2008-10-20 12:13 [PATCH] Format string bug in drivers/of/of_i2c.c Jon Smirl
@ 2008-10-21 2:52 ` Benjamin Herrenschmidt
2008-10-21 2:57 ` Jon Smirl
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2008-10-21 2:52 UTC (permalink / raw)
To: Jon Smirl; +Cc: linuxppc-dev
On Mon, 2008-10-20 at 08:13 -0400, Jon Smirl wrote:
> Format string bug. Not exploitable, as this is only writable by root,
> but worth fixing all the same.
Where is your signed-off-by ?
Cheers,
Ben.
> See 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b
> ---
> drivers/of/of_i2c.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
> index 6a98dc8..24bbef7 100644
> --- a/drivers/of/of_i2c.c
> +++ b/drivers/of/of_i2c.c
> @@ -41,7 +41,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
>
> info.addr = *addr;
>
> - request_module(info.type);
> + request_module("%s", info.type);
>
> result = i2c_new_device(adap, &info);
> if (result == NULL) {
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Format string bug in drivers/of/of_i2c.c
2008-10-21 2:52 ` Benjamin Herrenschmidt
@ 2008-10-21 2:57 ` Jon Smirl
0 siblings, 0 replies; 3+ messages in thread
From: Jon Smirl @ 2008-10-21 2:57 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev
Format string bug. Not exploitable, as this is only writable by root,
but worth fixing all the same.
See 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b
Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
---
drivers/of/of_i2c.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
index 6a98dc8..24bbef7 100644
--- a/drivers/of/of_i2c.c
+++ b/drivers/of/of_i2c.c
@@ -41,7 +41,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
info.addr = *addr;
- request_module(info.type);
+ request_module("%s", info.type);
result = i2c_new_device(adap, &info);
if (result == NULL) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-21 2:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-20 12:13 [PATCH] Format string bug in drivers/of/of_i2c.c Jon Smirl
2008-10-21 2:52 ` Benjamin Herrenschmidt
2008-10-21 2:57 ` Jon Smirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).