From: "Jon Smirl" <jonsmirl@gmail.com>
To: "Kumar Gala" <galak@kernel.crashing.org>
Cc: "Michael Weiser" <michael@weiser.dinsnail.net>,
"Rogério Brito" <rbrito@ime.usp.br>,
linuxppc-dev@ozlabs.org, "Scott Wood" <scottwood@freescale.com>,
"Guennadi Liakhovetski" <g.liakhovetski@gmx.de>
Subject: Re: [PATCH] fix i2c on PPC linkstation / kurobox machines
Date: Tue, 28 Oct 2008 10:06:18 -0400 [thread overview]
Message-ID: <9e4733910810280706n17bd94d7g7395b4e8beaa149a@mail.gmail.com> (raw)
In-Reply-To: <ED4FCA66-6032-4F4A-958C-8FD7DDB7CBE9@kernel.crashing.org>
On Tue, Oct 28, 2008 at 9:58 AM, Kumar Gala <galak@kernel.crashing.org> wrote:
>
> On Oct 23, 2008, at 6:05 PM, Guennadi Liakhovetski wrote:
>
>> i2c is broken on linkstation / kurobox machines since at least 2.6.27. Fix
>> it. Also remove CONFIG_SERIAL_OF_PLATFORM, which, if enabled, breaks the
>> serial console after the "console handover: boot [udbg0] -> real [ttyS1]"
>> message.
>>
>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>>
>> ---
>>
>> No, I do not really understand why I have to remove
>> CONFIG_SERIAL_OF_PLATFORM now after adding a call to
>> of_platform_bus_probe(), but it works this way. It must have something to
>> do with the legacy serial driver... If accepted in this form, I'll also
>> forward it to stable.
>>
>> diff --git
>
>
> applied to merge.
Did you change the comment? I2C wasn't broken, the bus definition was broken.
>
> - k
>
--
Jon Smirl
jonsmirl@gmail.com
prev parent reply other threads:[~2008-10-28 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081022191650.GA11406@weiser.dinsnail.net>
[not found] ` <Pine.LNX.4.64.0810232029380.9657@axis700.grange>
[not found] ` <20081023213309.GA19777@weiser.dinsnail.net>
2008-10-23 23:05 ` [PATCH] fix i2c on PPC linkstation / kurobox machines Guennadi Liakhovetski
2008-10-24 0:19 ` Benjamin Herrenschmidt
2008-10-24 18:25 ` Guennadi Liakhovetski
2008-10-28 13:58 ` Kumar Gala
2008-10-28 14:06 ` Jon Smirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910810280706n17bd94d7g7395b4e8beaa149a@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@weiser.dinsnail.net \
--cc=rbrito@ime.usp.br \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).