* [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft @ 2009-05-20 8:07 Wolfram Sang 2009-05-20 15:17 ` Jon Smirl 0 siblings, 1 reply; 10+ messages in thread From: Wolfram Sang @ 2009-05-20 8:07 UTC (permalink / raw) To: w.sang; +Cc: linuxppc-dev Add a node for the i2c eeprom and delete the superflous gpio-example. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Cc: Grant Likely <grant.likely@secretlab.ca> Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/boot/dts/pcm030.dts | 26 ++++---------------------- 1 files changed, 4 insertions(+), 22 deletions(-) diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts index 8958347..33ce488 100644 --- a/arch/powerpc/boot/dts/pcm030.dts +++ b/arch/powerpc/boot/dts/pcm030.dts @@ -258,34 +258,16 @@ compatible = "nxp,pcf8563"; reg = <0x51>; }; - /* FIXME: EEPROM */ + eeprom@52 { + compatible = "at24,24c32"; + reg = <0x52>; + }; }; sram@8000 { compatible = "fsl,mpc5200b-sram","fsl,mpc5200-sram"; reg = <0x8000 0x4000>; }; - - /* This is only an example device to show the usage of gpios. It maps all available - * gpios to the "gpio-provider" device. - */ - gpio { - compatible = "gpio-provider"; - - /* mpc52xx exp.con patchfield */ - gpios = <&gpio_wkup 0 0 /* GPIO_WKUP_7 11d jp13-3 */ - &gpio_wkup 1 0 /* GPIO_WKUP_6 14c */ - &gpio_wkup 6 0 /* PSC2_4 43c x5-11 */ - &gpio_simple 2 0 /* IRDA_1 24c x7-6 set GPS_PORT_CONFIG[IRDA] = 0 */ - &gpio_simple 3 0 /* IRDA_0 x8-5 set GPS_PORT_CONFIG[IRDA] = 0 */ - &gpt2 0 0 /* timer2 12d x4-4 */ - &gpt3 0 0 /* timer3 13d x6-4 */ - &gpt4 0 0 /* timer4 61c x2-16 */ - &gpt5 0 0 /* timer5 44c x7-11 */ - &gpt6 0 0 /* timer6 60c x8-15 */ - &gpt7 0 0 /* timer7 36a x17-9 */ - >; - }; }; pci@f0000d00 { -- 1.6.2 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft 2009-05-20 8:07 [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft Wolfram Sang @ 2009-05-20 15:17 ` Jon Smirl 2009-05-20 15:53 ` Wolfram Sang 0 siblings, 1 reply; 10+ messages in thread From: Jon Smirl @ 2009-05-20 15:17 UTC (permalink / raw) To: Wolfram Sang; +Cc: linuxppc-dev T24gV2VkLCBNYXkgMjAsIDIwMDkgYXQgNDowNyBBTSwgV29sZnJhbSBTYW5nIDx3LnNhbmdAcGVu Z3V0cm9uaXguZGU+IHdyb3RlOgo+IEFkZCBhIG5vZGUgZm9yIHRoZSBpMmMgZWVwcm9tIGFuZCBk ZWxldGUgdGhlIHN1cGVyZmxvdXMgZ3Bpby1leGFtcGxlLgo+Cj4gU2lnbmVkLW9mZi1ieTogV29s ZnJhbSBTYW5nIDx3LnNhbmdAcGVuZ3V0cm9uaXguZGU+Cj4gQ2M6IEdyYW50IExpa2VseSA8Z3Jh bnQubGlrZWx5QHNlY3JldGxhYi5jYT4KPiBDYzogbGludXhwcGMtZGV2QG96bGFicy5vcmcKPiAt LS0KPiCgYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3BjbTAzMC5kdHMgfCCgIDI2ICsrKystLS0tLS0t LS0tLS0tLS0tLS0tLS0tCj4goDEgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAyMiBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvcGNtMDMw LmR0cyBiL2FyY2gvcG93ZXJwYy9ib290L2R0cy9wY20wMzAuZHRzCj4gaW5kZXggODk1ODM0Ny4u MzNjZTQ4OCAxMDA2NDQKPiAtLS0gYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvcGNtMDMwLmR0cwo+ ICsrKyBiL2FyY2gvcG93ZXJwYy9ib290L2R0cy9wY20wMzAuZHRzCj4gQEAgLTI1OCwzNCArMjU4 LDE2IEBACj4goCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoGNvbXBhdGlibGUgPSAibnhw LHBjZjg1NjMiOwo+IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKByZWcgPSA8MHg1MT47 Cj4goCCgIKAgoCCgIKAgoCCgIKAgoCCgIKB9Owo+IC0goCCgIKAgoCCgIKAgoCCgIKAgoCCgIC8q IEZJWE1FOiBFRVBST00gKi8KPiArIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCBlZXByb21ANTIgewo+ ICsgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgY29tcGF0aWJsZSA9ICJhdDI0LDI0YzMy IjsKPiArIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIHJlZyA9IDwweDUyPjsKPiArIKAg oCCgIKAgoCCgIKAgoCCgIKAgoCB9OwoKR3JhbnQgc3VnZ2VzdGVkIHRoaXMgZWFybGllci4uLgoJ CQllZXByb21ANTIgewoJCQkJY29tcGF0aWJsZSA9ICJhdG1lbCwyNGMzMiIsICJlZXByb20iOwoJ CQkJcmVnID0gPDB4NTI+OwoJCQl9OwoKCgoKPiCgIKAgoCCgIKAgoCCgIKB9Owo+Cj4goCCgIKAg oCCgIKAgoCCgc3JhbUA4MDAwIHsKPiCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoGNvbXBhdGlibGUg PSAiZnNsLG1wYzUyMDBiLXNyYW0iLCJmc2wsbXBjNTIwMC1zcmFtIjsKPiCgIKAgoCCgIKAgoCCg IKAgoCCgIKAgoHJlZyA9IDwweDgwMDAgMHg0MDAwPjsKPiCgIKAgoCCgIKAgoCCgIKB9Owo+IC0K PiAtIKAgoCCgIKAgoCCgIKAgLyogVGhpcyBpcyBvbmx5IGFuIGV4YW1wbGUgZGV2aWNlIHRvIHNo b3cgdGhlIHVzYWdlIG9mIGdwaW9zLiBJdCBtYXBzIGFsbCBhdmFpbGFibGUKPiAtIKAgoCCgIKAg oCCgIKAgoCogZ3Bpb3MgdG8gdGhlICJncGlvLXByb3ZpZGVyIiBkZXZpY2UuCj4gLSCgIKAgoCCg IKAgoCCgIKAqLwo+IC0goCCgIKAgoCCgIKAgoCBncGlvIHsKPiAtIKAgoCCgIKAgoCCgIKAgoCCg IKAgoCBjb21wYXRpYmxlID0gImdwaW8tcHJvdmlkZXIiOwo+IC0KPiAtIKAgoCCgIKAgoCCgIKAg oCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgLyogbXBjNTJ4eCCgIKAgoCCgIKBl eHAuY29uIKAgoCCgIKAgcGF0Y2hmaWVsZCAqLwo+IC0goCCgIKAgoCCgIKAgoCCgIKAgoCCgIGdw aW9zID0gPCZncGlvX3drdXAgoCCgIDAgMCAvKiBHUElPX1dLVVBfNyCgIKAgoDExZCCgIKAgoCCg IKAgoCBqcDEzLTMgoCCgICovCj4gLSCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgJmdw aW9fd2t1cCCgIKAgMSAwIC8qIEdQSU9fV0tVUF82IKAgoCCgMTRjIKAgoCCgIKAgoCCgIKAgoCCg IKAgoCCgKi8KPiAtIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAmZ3Bpb193a3VwIKAg oCA2IDAgLyogUFNDMl80IKAgoCCgIKAgoCA0M2MgoCCgIKAgoCCgIKAgeDUtMTEgoCCgIKAqLwo+ IC0goCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCZncGlvX3NpbXBsZSCgIDIgMCAvKiBJ UkRBXzEgoCCgIKAgoCCgIDI0YyCgIKAgoCCgIKAgoCB4Ny02IKAgoHNldCBHUFNfUE9SVF9DT05G SUdbSVJEQV0gPSAwICovCj4gLSCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgJmdwaW9f c2ltcGxlIKAgMyAwIC8qIElSREFfMCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIHg4LTUgoCCg c2V0IEdQU19QT1JUX0NPTkZJR1tJUkRBXSA9IDAgKi8KPiAtIKAgoCCgIKAgoCCgIKAgoCCgIKAg oCCgIKAgoCCgIKAmZ3B0MiCgIKAgoCCgIKAwIDAgLyogdGltZXIyIKAgoCCgIKAgoCAxMmQgoCCg IKAgoCCgIKAgeDQtNCCgIKAgoCAqLwo+IC0goCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAg oCZncHQzIKAgoCCgIKAgoDAgMCAvKiB0aW1lcjMgoCCgIKAgoCCgIDEzZCCgIKAgoCCgIKAgoCB4 Ni00IKAgoCCgICovCj4gLSCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgJmdwdDQgoCCg IKAgoCCgMCAwIC8qIHRpbWVyNCCgIKAgoCCgIKAgNjFjIKAgoCCgIKAgoCCgIHgyLTE2IKAgoCCg Ki8KPiAtIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAmZ3B0NSCgIKAgoCCgIKAwIDAg LyogdGltZXI1IKAgoCCgIKAgoCA0NGMgoCCgIKAgoCCgIKAgeDctMTEgoCCgIKAqLwo+IC0goCCg IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCZncHQ2IKAgoCCgIKAgoDAgMCAvKiB0aW1lcjYg oCCgIKAgoCCgIDYwYyCgIKAgoCCgIKAgoCB4OC0xNSCgIKAgoCovCj4gLSCgIKAgoCCgIKAgoCCg IKAgoCCgIKAgoCCgIKAgoCCgJmdwdDcgoCCgIKAgoCCgMCAwIC8qIHRpbWVyNyCgIKAgoCCgIKAg MzZhIKAgoCCgIKAgoCCgIHgxNy05IKAgoCCgKi8KPiAtIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCg IKAgoCCgIKA+Owo+IC0goCCgIKAgoCCgIKAgoCB9Owo+IKAgoCCgIKB9Owo+Cj4goCCgIKAgoHBj aUBmMDAwMGQwMCB7Cj4gLS0KPiAxLjYuMgo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiBMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0Cj4gTGludXhw cGMtZGV2QG96bGFicy5vcmcKPiBodHRwczovL296bGFicy5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eHBwYy1kZXYKPgoKCgotLSAKSm9uIFNtaXJsCmpvbnNtaXJsQGdtYWlsLmNvbQo= ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft 2009-05-20 15:17 ` Jon Smirl @ 2009-05-20 15:53 ` Wolfram Sang 2009-05-20 16:10 ` Jon Smirl 0 siblings, 1 reply; 10+ messages in thread From: Wolfram Sang @ 2009-05-20 15:53 UTC (permalink / raw) To: Jon Smirl; +Cc: linuxppc-dev [-- Attachment #1: Type: text/plain, Size: 717 bytes --] > > - /* FIXME: EEPROM */ > > + eeprom@52 { > > + compatible = "at24,24c32"; > > + reg = <0x52>; > > + }; > > Grant suggested this earlier... > eeprom@52 { > compatible = "atmel,24c32", "eeprom"; > reg = <0x52>; > }; Can you give me a pointer? I just found this thread http://ozlabs.org/pipermail/devicetree-discuss/2008-July/000008.html but not the result you proposed. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft 2009-05-20 15:53 ` Wolfram Sang @ 2009-05-20 16:10 ` Jon Smirl 2009-05-20 16:15 ` Wolfram Sang 0 siblings, 1 reply; 10+ messages in thread From: Jon Smirl @ 2009-05-20 16:10 UTC (permalink / raw) To: Wolfram Sang, Grant Likely; +Cc: linuxppc-dev On Wed, May 20, 2009 at 11:53 AM, Wolfram Sang <w.sang@pengutronix.de> wrot= e: >> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* FIXME: EEPROM */ >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 eeprom@52 { >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatib= le =3D "at24,24c32"; >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D = <0x52>; >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; >> >> Grant suggested this earlier... >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 eeprom@52 { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible = =3D "atmel,24c32", "eeprom"; >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x5= 2>; >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > Can you give me a pointer? I just found this thread Grant, what do you want here? > http://ozlabs.org/pipermail/devicetree-discuss/2008-July/000008.html > > but not the result you proposed. > > Regards, > > =A0 Wolfram > > -- > Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | Wo= lfram Sang =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| > Industrial Linux Solutions =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | http://www.p= engutronix.de/ =A0| > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAkoUJ4oACgkQD27XaX1/VRsSbwCgo1o//DG1wjKGR7BY1lkRxOAi > 8kIAoJghKuhKMNBDXUhA4sWj/vRfDoDV > =3DBmoy > -----END PGP SIGNATURE----- > > --=20 Jon Smirl jonsmirl@gmail.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft 2009-05-20 16:10 ` Jon Smirl @ 2009-05-20 16:15 ` Wolfram Sang 2009-05-20 16:25 ` Grant Likely 0 siblings, 1 reply; 10+ messages in thread From: Wolfram Sang @ 2009-05-20 16:15 UTC (permalink / raw) To: Jon Smirl; +Cc: linuxppc-dev [-- Attachment #1: Type: text/plain, Size: 949 bytes --] On Wed, May 20, 2009 at 12:10:59PM -0400, Jon Smirl wrote: > On Wed, May 20, 2009 at 11:53 AM, Wolfram Sang <w.sang@pengutronix.de> wrote: > >> > - /* FIXME: EEPROM */ > >> > + eeprom@52 { > >> > + compatible = "at24,24c32"; > >> > + reg = <0x52>; > >> > + }; > >> > >> Grant suggested this earlier... > >> eeprom@52 { > >> compatible = "atmel,24c32", "eeprom"; > >> reg = <0x52>; > >> }; > > > > Can you give me a pointer? I just found this thread > > > Grant, what do you want here? I fear an answer like: "a properly working at24" ;) -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft 2009-05-20 16:15 ` Wolfram Sang @ 2009-05-20 16:25 ` Grant Likely 2009-05-20 16:36 ` Grant Likely 0 siblings, 1 reply; 10+ messages in thread From: Grant Likely @ 2009-05-20 16:25 UTC (permalink / raw) To: Wolfram Sang; +Cc: linuxppc-dev On Wed, May 20, 2009 at 10:15 AM, Wolfram Sang <w.sang@pengutronix.de> wrot= e: > On Wed, May 20, 2009 at 12:10:59PM -0400, Jon Smirl wrote: >> On Wed, May 20, 2009 at 11:53 AM, Wolfram Sang <w.sang@pengutronix.de> w= rote: >> >> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* FIXME: EEPROM */ >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 eeprom@52 { >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compa= tible =3D "at24,24c32"; >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg = =3D <0x52>; >> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; >> >> >> >> Grant suggested this earlier... >> >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 eeprom@52 { >> >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatibl= e =3D "atmel,24c32", "eeprom"; >> >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <= 0x52>; >> >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; >> > >> > Can you give me a pointer? I just found this thread >> >> >> Grant, what do you want here? > > I fear an answer like: "a properly working at24" ;) > BWAHAHAHAHA! g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft 2009-05-20 16:25 ` Grant Likely @ 2009-05-20 16:36 ` Grant Likely 2009-05-20 22:59 ` [PATCH V2] " Wolfram Sang 2009-05-21 17:43 ` [PATCH] " Segher Boessenkool 0 siblings, 2 replies; 10+ messages in thread From: Grant Likely @ 2009-05-20 16:36 UTC (permalink / raw) To: Wolfram Sang; +Cc: linuxppc-dev On Wed, May 20, 2009 at 10:25 AM, Grant Likely <grant.likely@secretlab.ca> wrote: > On Wed, May 20, 2009 at 10:15 AM, Wolfram Sang <w.sang@pengutronix.de> wr= ote: >> On Wed, May 20, 2009 at 12:10:59PM -0400, Jon Smirl wrote: >>> On Wed, May 20, 2009 at 11:53 AM, Wolfram Sang <w.sang@pengutronix.de> = wrote: >>> >> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* FIXME: EEPROM */ >>> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 eeprom@52 { >>> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 comp= atible =3D "at24,24c32"; >>> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg = =3D <0x52>; >>> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; >>> >> >>> >> Grant suggested this earlier... >>> >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 eeprom@52 { >>> >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatib= le =3D "atmel,24c32", "eeprom"; >>> >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D = <0x52>; >>> >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; >>> > >>> > Can you give me a pointer? I just found this thread >>> >>> >>> Grant, what do you want here? >> >> I fear an answer like: "a properly working at24" ;) >> > > BWAHAHAHAHA! Now that I've got that out of the way... As the other thread states, "eeprom" is far too vague, and it is certainly not documented, and does not say anything meaningful about the protocol used to talk to the eeprom. Sure, most i2c eeproms use the same protocol, but an assumption cannot be made that that will always be the case. Plus, the namespace will collide with non-i2c eeproms. "i2c-eeprom" is better, but not great. Before a value like "i2c-eeprom" can be acceptable, it must be documented and reviewed as to exactly what it means, and even then I'm uncomfortable with it. However, on the other point, Jon is correct. The first value in the list should be "atmel,24c32", not "at24,24c32". Cheers, g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V2] powerpc/pcm030.dts: add i2c eeprom and delete cruft 2009-05-20 16:36 ` Grant Likely @ 2009-05-20 22:59 ` Wolfram Sang 2009-05-21 17:43 ` [PATCH] " Segher Boessenkool 1 sibling, 0 replies; 10+ messages in thread From: Wolfram Sang @ 2009-05-20 22:59 UTC (permalink / raw) To: w.sang; +Cc: linuxppc-dev Add a node for the i2c eeprom and delete the superflous gpio-example. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Cc: Grant Likely <grant.likely@secretlab.ca> Cc: linuxppc-dev@ozlabs.org --- Changes since V1: use vendor name in eeprom-node arch/powerpc/boot/dts/pcm030.dts | 26 ++++---------------------- 1 files changed, 4 insertions(+), 22 deletions(-) diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts index 8958347..30bfdc0 100644 --- a/arch/powerpc/boot/dts/pcm030.dts +++ b/arch/powerpc/boot/dts/pcm030.dts @@ -258,34 +258,16 @@ compatible = "nxp,pcf8563"; reg = <0x51>; }; - /* FIXME: EEPROM */ + eeprom@52 { + compatible = "catalyst,24c32"; + reg = <0x52>; + }; }; sram@8000 { compatible = "fsl,mpc5200b-sram","fsl,mpc5200-sram"; reg = <0x8000 0x4000>; }; - - /* This is only an example device to show the usage of gpios. It maps all available - * gpios to the "gpio-provider" device. - */ - gpio { - compatible = "gpio-provider"; - - /* mpc52xx exp.con patchfield */ - gpios = <&gpio_wkup 0 0 /* GPIO_WKUP_7 11d jp13-3 */ - &gpio_wkup 1 0 /* GPIO_WKUP_6 14c */ - &gpio_wkup 6 0 /* PSC2_4 43c x5-11 */ - &gpio_simple 2 0 /* IRDA_1 24c x7-6 set GPS_PORT_CONFIG[IRDA] = 0 */ - &gpio_simple 3 0 /* IRDA_0 x8-5 set GPS_PORT_CONFIG[IRDA] = 0 */ - &gpt2 0 0 /* timer2 12d x4-4 */ - &gpt3 0 0 /* timer3 13d x6-4 */ - &gpt4 0 0 /* timer4 61c x2-16 */ - &gpt5 0 0 /* timer5 44c x7-11 */ - &gpt6 0 0 /* timer6 60c x8-15 */ - &gpt7 0 0 /* timer7 36a x17-9 */ - >; - }; }; pci@f0000d00 { -- 1.6.2 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft 2009-05-20 16:36 ` Grant Likely 2009-05-20 22:59 ` [PATCH V2] " Wolfram Sang @ 2009-05-21 17:43 ` Segher Boessenkool 2009-05-21 17:58 ` Grant Likely 1 sibling, 1 reply; 10+ messages in thread From: Segher Boessenkool @ 2009-05-21 17:43 UTC (permalink / raw) To: Grant Likely; +Cc: linuxppc-dev > As the other thread states, "eeprom" is far too vague, and it is > certainly not documented, and does not say anything meaningful about > the protocol used to talk to the eeprom. Sure, most i2c eeproms use > the same protocol, Not at all! Pretty much every size of 24c has its own protocol; and some manufacturers have special extensions for locking parts of the array, etc. A driver can ignore that last part, but not the first. So the SEEPROM size should be part of its "compatible" name; simplest way for that is to use the model number. > but an assumption cannot be made that that will > always be the case. Plus, the namespace will collide with non-i2c > eeproms. "i2c-eeprom" is better, but not great. Before a value like > "i2c-eeprom" can be acceptable, it must be documented and reviewed as > to exactly what it means, and even then I'm uncomfortable with it. > > However, on the other point, Jon is correct. The first value in the > list should be "atmel,24c32", not "at24,24c32". Yeah. So perhaps "atmel,24c32","24c32" ? I'm not terribly happy with that last name, but these devices are _very_ common. Segher ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft 2009-05-21 17:43 ` [PATCH] " Segher Boessenkool @ 2009-05-21 17:58 ` Grant Likely 0 siblings, 0 replies; 10+ messages in thread From: Grant Likely @ 2009-05-21 17:58 UTC (permalink / raw) To: Segher Boessenkool; +Cc: linuxppc-dev On Thu, May 21, 2009 at 11:43 AM, Segher Boessenkool <segher@kernel.crashing.org> wrote: >> However, on the other point, Jon is correct. =A0The first value in the >> list should be "atmel,24c32", not "at24,24c32". > > Yeah. =A0So perhaps "atmel,24c32","24c32" ? =A0I'm not terribly happy > with that last name, but these devices are _very_ common. I don't think the last name is necessary at all. I'd leave it at "atmel,24c32". non-atmel parts can claim compatibility with the atmel version if really necessary. I don't like the 'generic' version either. g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2009-05-21 17:59 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-05-20 8:07 [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft Wolfram Sang 2009-05-20 15:17 ` Jon Smirl 2009-05-20 15:53 ` Wolfram Sang 2009-05-20 16:10 ` Jon Smirl 2009-05-20 16:15 ` Wolfram Sang 2009-05-20 16:25 ` Grant Likely 2009-05-20 16:36 ` Grant Likely 2009-05-20 22:59 ` [PATCH V2] " Wolfram Sang 2009-05-21 17:43 ` [PATCH] " Segher Boessenkool 2009-05-21 17:58 ` Grant Likely
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).