linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jon Smirl <jonsmirl@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH V2 1/9] Register the wm9712 DAIs on module load
Date: Sun, 24 May 2009 11:28:15 -0400	[thread overview]
Message-ID: <9e4733910905240828q4b4cfd96xe840f3ae983143dc@mail.gmail.com> (raw)
In-Reply-To: <20090524111118.GC4933@sirena.org.uk>

On Sun, May 24, 2009 at 7:11 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Sat, May 23, 2009 at 07:12:57PM -0400, Jon Smirl wrote:
>> Register the wm9712 DAIs on module load
>
>> Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
>
> Why do you wish to do this - ASoC does not require or use DAI registration
> for AC97 CODECs?
>

Then what is wrong with my binding code? If I take out the
registration my bind fails.

static struct snd_soc_dai_link pcm030_fabric_dai[] = {
{
	.name = "AC97",
	.stream_name = "AC97 Analog",
	.codec_dai = &wm9712_dai[WM9712_DAI_AC97_HIFI],
	.cpu_dai = &psc_ac97_dai[MPC5200_AC97_NORMAL],
},
{
	.name = "AC97",
	.stream_name = "AC97 IEC958",
	.codec_dai = &wm9712_dai[WM9712_DAI_AC97_AUX],
	.cpu_dai = &psc_ac97_dai[MPC5200_AC97_SPDIF],
},
};

static __init int pcm030_fabric_init(void)
{
	struct platform_device *pdev;
	int rc;

	if (!machine_is_compatible("phytec,pcm030"))
		return -ENODEV;

	card.platform = &mpc5200_audio_dma_platform;
	card.name = "pcm030";
	card.dai_link = pcm030_fabric_dai;
	card.num_links = ARRAY_SIZE(pcm030_fabric_dai);

	device.card = &card;
	device.codec_dev = &soc_codec_dev_wm9712;

	pdev = platform_device_alloc("soc-audio", 1);
	if (!pdev) {
		pr_err("pcm030_fabric_init: platform_device_alloc() failed\n");
		return -ENODEV;
	}

	platform_set_drvdata(pdev, &device);
	device.dev = &pdev->dev;

	rc = platform_device_add(pdev);
	if (rc) {
		pr_err("pcm030_fabric_init: platform_device_add() failed\n");
		return -ENODEV;
	}
	return 0;
}


Advanced Linux Sound Architecture Driver Version 1.0.19.
No device for DAI stac9766 analog
No device for DAI stac9766 IEC958
No device for DAI tas5504
irq: irq 129 on host /soc5200@f0000000/interrupt-controller@500 mapped
to virtual irq 129
irq: irq 194 on host /soc5200@f0000000/interrupt-controller@500 mapped
to virtual irq 194
irq: irq 195 on host /soc5200@f0000000/interrupt-controller@500 mapped
to virtual irq 195
mpc5200-psc-ac97 f0002000.ac97: Codec ID is 574d 4c12
ALSA device list:
  No soundcards found.





-- 
Jon Smirl
jonsmirl@gmail.com

  reply	other threads:[~2009-05-24 15:28 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-23 23:12 [PATCH V2 0/9] mpc5200 audio rework for AC97 Jon Smirl
2009-05-23 23:12 ` [PATCH V2 1/9] Register the wm9712 DAIs on module load Jon Smirl
2009-05-24 11:11   ` [alsa-devel] " Mark Brown
2009-05-24 15:28     ` Jon Smirl [this message]
2009-05-24 15:32       ` Jon Smirl
2009-05-24 19:14       ` Mark Brown
2009-05-23 23:12 ` [PATCH V2 2/9] Basic split of mpc5200 DMA code out from mpc5200_psc_i2s Jon Smirl
2009-05-24 14:11   ` Grant Likely
2009-05-23 23:13 ` [PATCH V2 3/9] Rename the PSC functions to DMA Jon Smirl
2009-05-24 11:15   ` [alsa-devel] " Mark Brown
2009-05-24 14:12     ` Grant Likely
2009-05-23 23:13 ` [PATCH V2 4/9] Add a few more mpc5200 PSC defines Jon Smirl
2009-05-24 14:13   ` Grant Likely
2009-05-24 18:00     ` Mark Brown
2009-05-24 18:19       ` Grant Likely
2009-05-24 18:32         ` [alsa-devel] " Mark Brown
2009-05-23 23:13 ` [PATCH V2 5/9] Main rewite of the mpc5200 audio DMA code Jon Smirl
2009-05-24 11:26   ` [alsa-devel] " Mark Brown
2009-05-24 18:55   ` Wolfram Sang
2009-05-24 20:10     ` Jon Smirl
2009-05-24 20:35       ` Wolfram Sang
2009-05-25  7:56       ` Juergen Beisert
2009-05-25 10:51         ` Mark Brown
2009-05-23 23:13 ` [PATCH V2 6/9] Codec for STAC9766 used on the Efika Jon Smirl
2009-05-24 11:46   ` [alsa-devel] " Mark Brown
2009-05-23 23:13 ` [PATCH V2 7/9] AC97 driver for mpc5200 Jon Smirl
2009-05-24 12:10   ` [alsa-devel] " Mark Brown
2009-05-23 23:13 ` [PATCH V2 8/9] Fabric bindings for STAC9766 on the Efika Jon Smirl
2009-05-24 12:12   ` [alsa-devel] " Mark Brown
2009-05-23 23:13 ` [PATCH V2 9/9] Support for AC97 on Phytec pmc030 base board Jon Smirl
2009-05-24 12:13   ` [alsa-devel] " Mark Brown
2009-05-23 23:20 ` [PATCH V2 0/9] mpc5200 audio rework for AC97 Jon Smirl
2009-05-24 11:08 ` [alsa-devel] " Mark Brown
2009-05-24 15:21   ` Jon Smirl
2009-05-24 18:35     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e4733910905240828q4b4cfd96xe840f3ae983143dc@mail.gmail.com \
    --to=jonsmirl@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).