From: Jon Smirl <jonsmirl@gmail.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org,
broonie@sirena.org.uk
Subject: Re: [PATCH] alsa/soc: add locking to mpc5200-psc-ac97 driver
Date: Tue, 30 Jun 2009 14:33:18 -0400 [thread overview]
Message-ID: <9e4733910906301133n4928cfc4h3ce4ee2aef53fa73@mail.gmail.com> (raw)
In-Reply-To: <fa686aa40906300950m15b7d48av953c0c738f6bf0e7@mail.gmail.com>
On Tue, Jun 30, 2009 at 12:50 PM, Grant Likely<grant.likely@secretlab.ca> w=
rote:
> On Tue, Jun 30, 2009 at 12:18 AM, Wolfram Sang<w.sang@pengutronix.de> wro=
te:
>>> +
>>> + =A0 =A0 /* Force clear the data valid bit */
>>> + =A0 =A0 in_be32(&psc_dma->psc_regs->ac97_data);
>>> +
>>
>> No mutex involved here. I think this is either a separate patch or it ne=
eds at
>> least to be mentioned in the patch description.
>
> Oops, that was sloppy. =A0Yes, I'll put this into a separate patch. =A0Th=
anks.
Now that you have added the mutexes, do you ever need to force clear
the valid bit?
Maybe log an error if this happens so that we can track down why.
--=20
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2009-07-01 0:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 23:42 [PATCH] alsa/soc: add locking to mpc5200-psc-ac97 driver Grant Likely
2009-06-30 0:26 ` Jon Smirl
2009-06-30 8:59 ` Mark Brown
2009-06-30 16:53 ` Grant Likely
2009-06-30 6:18 ` Wolfram Sang
2009-06-30 13:42 ` Jon Smirl
2009-06-30 13:53 ` Mark Brown
2009-07-01 8:56 ` Wolfram Sang
2009-07-01 13:32 ` Jon Smirl
2009-07-01 13:55 ` Wolfram Sang
2009-07-01 14:44 ` Grant Likely
2009-07-02 13:51 ` Eric Millbrandt
2009-06-30 16:50 ` Grant Likely
2009-06-30 18:33 ` Jon Smirl [this message]
2009-06-30 19:08 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910906301133n4928cfc4h3ce4ee2aef53fa73@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).