Re: [PATCH v2 31/36] soc: fsl: cpm1: qmc: Introduce qmc_version

[Christophe Leroy <christophe.leroy@csgroup.eu>]

Le 08/08/2024 à 09:11, Herve Codina a écrit :
> Current code handles the CPM1 version of QMC.
> 
> In order to prepare the support for the QUICC Engine (QE) version of
> QMC, introduce qmc_version to identify versions. This will enable the
> code to make the distinction between several QMC implementations.
> 
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
>   drivers/soc/fsl/qe/qmc.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index 062477b7426e..8ff7eaaa4c50 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -215,7 +215,12 @@ struct qmc_chan {
>   	bool	is_rx_stopped;
>   };
>   
> +enum qmc_version {
> +	QMC_CPM1,
> +};
> +
>   struct qmc_data {
> +	enum qmc_version version;
>   	u32 tstate; /* Initial TSTATE value */
>   	u32 rstate; /* Initial RSTATE value */
>   	u32 zistate; /* Initial ZISTATE value */
> @@ -1811,6 +1816,7 @@ static void qmc_remove(struct platform_device *pdev)
>   }
>   
>   static const struct qmc_data qmc_data_cpm1 = {
> +	.version = QMC_CPM1,
>   	.tstate = 0x30000000,
>   	.rstate = 0x31000000,
>   	.zistate = 0x00000100,