From: Remis Lima Baima <remisbaima@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Arnd Bergmann <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC
Date: Mon, 9 Feb 2009 14:08:26 +0100 [thread overview]
Message-ID: <9fe197cb0902090508v514808c9wc558c18b96ceaa6a@mail.gmail.com> (raw)
In-Reply-To: <20090209094014.GE7930@elte.hu>
I have just tried the patch here and everything worked great!
Very well done.
On Mon, Feb 9, 2009 at 10:40 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
>>
>> Paul,
>>
>> I found the bug that was causing large modules to fail in setting
>> up dynamic ftrace. It wound up being a simple math error. To calculate
>> the offset in the TOC, I had used an OR, but the bottom half was
>> a signed extended short, and it should have been an addition.
>> The fix is in my tree below, as well as posted here.
>
> Looks like a .29 candidate?
>
> Ingo
I agree. A functional ("out-of-the-box") dynamic-ftrace helps quite a lot ;-)
Regards,
Remis
next prev parent reply other threads:[~2009-02-09 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 6:22 [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC Steven Rostedt
2009-02-09 9:40 ` Ingo Molnar
2009-02-09 13:08 ` Remis Lima Baima [this message]
2009-02-09 15:02 ` Steven Rostedt
2009-02-09 15:24 ` Ingo Molnar
2009-02-09 22:21 ` Benjamin Herrenschmidt
2009-02-09 20:16 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fe197cb0902090508v514808c9wc558c18b96ceaa6a@mail.gmail.com \
--to=remisbaima@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).