From: Andy Fleming <afleming@freescale.com>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev@ozlabs.org, jdl@jdl.com
Subject: Re: [RFC 5/7] Unite all PCI-e on 85xx and 86xx under one codebase
Date: Tue, 20 Feb 2007 16:03:41 -0600 [thread overview]
Message-ID: <A13088DB-319F-4EAA-941F-EC2D9D45F6D0@freescale.com> (raw)
In-Reply-To: <20070218142926.GA29002@lixom.net>
On Feb 18, 2007, at 08:29, Olof Johansson wrote:
> On Thu, Feb 15, 2007 at 08:46:03PM -0600, Andy Fleming wrote:
>> if (devfn != 0x0 && bus->number == 0xff)
>> return PCIBIOS_DEVICE_NOT_FOUND;
>>
>> + PCI_CFG_OUT(hose->cfg_addr, 0x80000000 | 0x4 << 24
>> + | (0 << 16) | (0x4 & 0xfc));
>> + link_training_stat = in_le32(hose->cfg_data);
>> + if ((link_training_stat & 0x5f) < 0x16) /* Training failure */
>> + return PCIBIOS_DEVICE_NOT_FOUND;
>> +
>
> Huh? (0x4 & 0xfc) doesn't make much sense, neither does 0 << 16. Can't
> you just hardcode the full hex value there, if you're not going to
> use symbolic constants, there's not much use in or:ing stuff together
> anyway. I.e. 0x84000004
Agreed
Andy
prev parent reply other threads:[~2007-02-20 22:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 2:46 [RFC 5/7] Unite all PCI-e on 85xx and 86xx under one codebase Andy Fleming
2007-02-18 14:29 ` Olof Johansson
2007-02-20 22:03 ` Andy Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A13088DB-319F-4EAA-941F-EC2D9D45F6D0@freescale.com \
--to=afleming@freescale.com \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).