linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sachin Sant <sachinp@linux.ibm.com>
To: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: irogers@google.com, maddy@linux.ibm.com, kjain@linux.ibm.com,
	acme@kernel.org, linux-perf-users@vger.kernel.org,
	jolsa@kernel.org, namhyung@kernel.org,
	disgoel@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] perf test: Fix parse-events tests to skip parametrized events
Date: Mon, 7 Aug 2023 11:40:16 +0530	[thread overview]
Message-ID: <A776945C-DDE0-4A12-960E-50641D237C6F@linux.ibm.com> (raw)
In-Reply-To: <20230807045016.23409-1-atrajeev@linux.vnet.ibm.com>



> On 07-Aug-2023, at 10:20 AM, Athira Rajeev <atrajeev@linux.vnet.ibm.com> wrote:
> 
> Testcase "Parsing of all PMU events from sysfs" parse events for
> all PMUs, and not just cpu. In case of powerpc, the PowerVM
> environment supports events from hv_24x7 and hv_gpci PMU which
> is of example format like below:
> 
> - hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/
> - hv_gpci/event,partition_id=?/
> 
> The value for "?" needs to be filled in depending on system
> configuration. It is better to skip these parametrized events
> in this test as it is done in:
> 'commit b50d691e50e6 ("perf test: Fix "all PMU test" to skip
> parametrized events")' which handled a simialr instance with
> "all PMU test".
> 
> Fix parse-events test to skip parametrized events since
> it needs proper setup of the parameters.
> 
> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
> —

Thanks Athira for the fix. With this fix applied the reported problem
Is fixed.

6.1: Test event parsing                                            : Ok
  6.2: Parsing of all PMU events from sysfs             : Ok
  6.3: Parsing of given PMU events from sysfs        : Ok

Tested-by: Sachin Sant <sachinp@linux.ibm.com>

- Sachin

  reply	other threads:[~2023-08-07  6:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07  4:50 [PATCH] perf test: Fix parse-events tests to skip parametrized events Athira Rajeev
2023-08-07  6:10 ` Sachin Sant [this message]
2023-08-17 17:30   ` Athira Rajeev
2023-08-17 18:37 ` Ian Rogers
2023-09-07 16:55   ` Athira Rajeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A776945C-DDE0-4A12-960E-50641D237C6F@linux.ibm.com \
    --to=sachinp@linux.ibm.com \
    --cc=acme@kernel.org \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=disgoel@linux.vnet.ibm.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kjain@linux.ibm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).