From: Kumar Gala <galak@kernel.crashing.org>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 3/4] powerpc: rtc_cmos_setup: assign interrupts only if there is i8259 PIC
Date: Mon, 28 Jul 2008 07:54:27 -0500 [thread overview]
Message-ID: <A87B5E3B-45CE-4EED-B998-41DE34119F99@kernel.crashing.org> (raw)
In-Reply-To: <20080611230431.GC21351@polina.dev.rtsoft.ru>
On Jun 11, 2008, at 6:04 PM, Anton Vorontsov wrote:
> i8259 PIC is disabled on MPC8610HPCD boards, thus currently rtc-cmos
> driver fails to probe.
>
> To fix the issue, we lookup the device tree for "chrp,iic" and
> "pnpPNP,000" compatible devices, and if not found we do not assign RTC
> IRQ and assuming that i8259 was disabled.
>
> Though this patch fixes RTC on some boards (and surely should not
> break
> any other), the whole approach is still broken. We can't easily fix
> this
> though, because old device trees do not specify i8259 interrupts for
> the
> cmos rtc node.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/sysdev/rtc_cmos_setup.c | 23 +++++++++++++++++------
> 1 files changed, 17 insertions(+), 6 deletions(-)
applied.
- k
next prev parent reply other threads:[~2008-07-28 12:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 23:02 [PATCH 0/4] Fix RTC for MPC8572DS and support RTC on MPC8610HPCD Anton Vorontsov
2008-06-11 23:04 ` [PATCH 1/4] powerpc: fsl_uli1575: fix RTC quirk to work on MPC8572DS and MPC8610HPCD Anton Vorontsov
2008-07-15 13:25 ` Kumar Gala
2008-06-11 23:04 ` [PATCH 2/4] powerpc/85xx/86xx: some refactoring for fsl_uli1575 code Anton Vorontsov
2008-06-11 23:04 ` [PATCH 3/4] powerpc: rtc_cmos_setup: assign interrupts only if there is i8259 PIC Anton Vorontsov
2008-07-28 12:54 ` Kumar Gala [this message]
2008-06-11 23:04 ` [PATCH 4/4] powerpc/86xx: mpc8610_hpcd: add support for ULI RTC Anton Vorontsov
2008-07-15 13:31 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A87B5E3B-45CE-4EED-B998-41DE34119F99@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).