From: Kumar Gala <galak@kernel.crashing.org>
To: Anton Vorontsov <avorontsov@mvista.com>
Cc: LEROY Christophe <christophe.leroy@c-s.fr>,
linuxppc-dev@ozlabs.org, Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH 2/3] powerpc/cpm1: Fix build with various CONFIG_*_UCODE_PATCH combinations
Date: Sun, 11 Jul 2010 11:07:09 -0500 [thread overview]
Message-ID: <AA37EC26-C5D9-45F4-8854-D95669EA043A@kernel.crashing.org> (raw)
In-Reply-To: <20100708171614.GB11621@oksana.dev.rtsoft.ru>
On Jul 8, 2010, at 12:16 PM, Anton Vorontsov wrote:
> Warnings are treated as errors for arch/powerpc code, so build fails
> with CONFIG_I2C_SPI_UCODE_PATCH=y:
>
> CC arch/powerpc/sysdev/micropatch.o
> cc1: warnings being treated as errors
> arch/powerpc/sysdev/micropatch.c: In function 'cpm_load_patch':
> arch/powerpc/sysdev/micropatch.c:630: warning: unused variable 'smp'
> make[1]: *** [arch/powerpc/sysdev/micropatch.o] Error 1
>
> And with CONFIG_USB_SOF_UCODE_PATCH=y:
>
> CC arch/powerpc/sysdev/micropatch.o
> cc1: warnings being treated as errors
> arch/powerpc/sysdev/micropatch.c: In function 'cpm_load_patch':
> arch/powerpc/sysdev/micropatch.c:629: warning: unused variable 'spp'
> arch/powerpc/sysdev/micropatch.c:628: warning: unused variable 'iip'
> make[1]: *** [arch/powerpc/sysdev/micropatch.o] Error 1
>
> This patch fixes these issues by introducing proper #ifdefs.
>
> Cc: <stable@kernel.org> [ .33, .34 ]
> Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
> ---
> arch/powerpc/sysdev/micropatch.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
applied to merge
- k
prev parent reply other threads:[~2010-07-11 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 17:16 [PATCH 2/3] powerpc/cpm1: Fix build with various CONFIG_*_UCODE_PATCH combinations Anton Vorontsov
2010-07-11 16:07 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AA37EC26-C5D9-45F4-8854-D95669EA043A@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=avorontsov@mvista.com \
--cc=christophe.leroy@c-s.fr \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox