From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D001ADDF1C for ; Wed, 29 Apr 2009 23:43:30 +1000 (EST) Message-Id: From: Kumar Gala To: Ben Dooks In-Reply-To: <20090422215646.GA19997@trinity.fluff.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: [PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL Date: Wed, 29 Apr 2009 08:43:14 -0500 References: <49EDC0BE.7040505@elphinstone.net> <20090422215646.GA19997@trinity.fluff.org> Cc: Linuxppc-dev Development , linux-i2c@vger.kernel.org, Mark Ware List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Apr 22, 2009, at 4:56 PM, Ben Dooks wrote: > On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala wrote: >> >> On Apr 21, 2009, at 7:49 AM, Mark Ware wrote: >> >>> Recent DMA changes result in a BUG() when NULL is passed to >>> dma_alloc_coherent in place of a device. >>> >>> Signed-off-by: Mark Ware >>> --- >>> >>> This patch fixes the BUG() during boot that has appeared during the >>> 2.6.30 window. It has been tested and appears correct on my 8280 >>> based >>> board. >>> Sent to both linuxppc-dev and linux-i2c, since I'm not sure where it >>> belongs. >>> >>> >>> drivers/i2c/busses/i2c-cpm.c | 14 ++++++++------ >>> 1 files changed, 8 insertions(+), 6 deletions(-) >> >> Acked-by: Kumar Gala >> >> Ben, I'm expecting you to pick this up unless you tell me otherwise. > > Yes. This go in yet? - k