From: Jon Smirl <jonsmirl@gmail.com>
To: Wolfgang Denk <wd@denx.de>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
linuxppc-dev@lists.ozlabs.org,
Eric Millbrandt <emillbrandt@dekaresearch.com>
Subject: Re: [PATCH 0/2] mpc5200 ac97 gpio reset
Date: Wed, 9 Jun 2010 08:21:41 -0400 [thread overview]
Message-ID: <AANLkTikDE14Y_r7nMpj5lNMy5anAyU3cuLjk_uxStHvo@mail.gmail.com> (raw)
In-Reply-To: <20100609061330.620AC14E867@gemini.denx.de>
On Wed, Jun 9, 2010 at 2:13 AM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Jon Smirl,
>
> In message <AANLkTimIs90kR5uqhdBQ02oSd94dn08sOITm51Ylrl4-@mail.gmail.com>=
you wrote:
>>
>> Would making a change in uboot be a better solution? Eric, can you
>> verify if changing uboot also fixes the problem?
>
> To me it seems better if the driver itself does what needs to be done
> instead of relying on specific settings that may or may not be done in
> U-Boot. Keep in mind that drivers may be loaded as modules, and that
> we even see cases where the same port serves multiple purposes by
> loading different driver modules (yes, this is not exactly a clever
> idea, but hardware designers come up with such solutions).
Someone with a scope can verify this, but my understanding of what
happens is that uboot by default puts the pins into GPIO mode. Linux
boots and reprograms the pins into AC97 mode. When the pins are
reprogrammed it generates glitches on the reset line. About half of
the time these glitches put the attached codec into test mode. Once
the chip is in test mode it won't respond to normal commands.
Does the opposite happen? What if uboot has the pins in AC97 mode and
Linux reprograms them into GPIO mode. Will it also put the chip into
test mode? The piece of information I've been missing is an
understanding of what is making the glitches that trigger test mode.
Another strategy would be to leave reset as is. If the chip is
unresponsive send it the commands to get it out of test mode. That
could be made part of the reset logic in the Linux driver.
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, =A0 =A0 MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
> The typical page layout program is nothing more =A0than =A0an =A0electron=
ic
> light table for cutting and pasting documents.
>
--=20
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2010-06-09 12:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 16:46 [PATCH 0/2] mpc5200 ac97 gpio reset Eric Millbrandt
2010-06-08 16:46 ` [PATCH 1/2] powerpc/5200: Export port-config Eric Millbrandt
2010-06-08 16:46 ` [PATCH 2/2] sound/soc: mpc5200_psc_ac97: Use gpio pins for cold reset Eric Millbrandt
2010-06-09 10:25 ` Mark Brown
2010-06-10 22:11 ` [PATCH 1/2] powerpc/5200: Export port-config Grant Likely
2010-06-09 0:24 ` [PATCH 0/2] mpc5200 ac97 gpio reset Jon Smirl
2010-06-09 6:13 ` Wolfgang Denk
2010-06-09 10:30 ` Mark Brown
2010-06-09 14:24 ` Eric Millbrandt
2010-06-10 22:07 ` Grant Likely
2010-06-10 23:14 ` Mark Brown
2010-06-10 23:31 ` Grant Likely
2010-06-09 12:21 ` Jon Smirl [this message]
2010-06-09 14:21 ` Eric Millbrandt
2010-06-09 14:32 ` Mark Brown
2010-06-09 14:41 ` Jon Smirl
2010-06-09 15:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikDE14Y_r7nMpj5lNMy5anAyU3cuLjk_uxStHvo@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=emillbrandt@dekaresearch.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).