From: Tirumala Marri <tmarri@apm.com>
To: Neil Jones <neiljay@gmail.com>
Cc: linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V6 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver
Date: Wed, 15 Dec 2010 14:50:20 -0800 [thread overview]
Message-ID: <AANLkTim4nh-9mL=ziAKbcRa2kZnoQk0pinREZ0qMYuqN@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikOituTX-gTQrr7cr2bXdbvf=A2UqHX0yVf8UDP@mail.gmail.com>
On Wed, Dec 15, 2010 at 2:17 AM, Neil Jones <neiljay@gmail.com> wrote:
> Hi,
>
> I've looked at the patches but your email states there are 10 patches,
> I can't see #1 and #10, only 2- 8 ??
>
> It doesn't look like you have resolved the lockdep issues we have been
> seeing, please get in contact as it
> would be good to discuss our issues with this driver ( and our distain
> for Synopsis ;-) ).
>
> Cheers
>
> Neil
>
> On Mon, Dec 13, 2010 at 3:48 PM, Neil Jones <neiljay@gmail.com> wrote:
>> Hi,
>>
>> We are currently using the latest version of this Synopsis IP in some
>> of our customers SoC's.
>>
>> The latest hardware adds a new DMA mode which is less Interrupt
>> intensive as well as a few other features.
>>
>> I have spent (and im still spending) a long time fixing up this driver
>> to be linux standards compliant with the intention of pushing it
>> upstream once complete, its still not ready yet.
>>
>> One of the major issues we had is the driver isn't SMP safe, I've not
>> had chance to review your patches yet but have your run the driver
>> with lock checking turned on ?
>>
>> Would it be possible to get the changes for the latest version of the
>> IP merged into this driver, I can supply my current version as a
>> reference.
>>
>> In my driver :
>>
>> Currently host support is working well and i've tested it with
>> multiple devices and done the test outlined on
>> http://www.linux-usb.org/usbtest/, the driver passed checkpatches and
>> runs with lockdeps on and on a SMP system, Im still working on the
>> device mode (PCD) part of the driver generally it works, but im still
>> getting the odd lock dep warning and a panic on un-loading of certain
>> gadget kernel modules. The only issue with our driver is I have not
>> converted all the bitfield usage to macros so it might make diffing a
>> pain.
>>
>> Cheers
>>
>> Neil
Hi,
Sorry for the late reply, I was busy working on the patch. Idea is to
functional patch for PPC architecture initially and extend that to SMP
and resolve other bugs if there at all. To push all the features in
one go is kind
of hard and increases the size of patches.
Sure let us discuss further if there are know issues need to be resolved
in the driver.
Thanks,
Marri
next prev parent reply other threads:[~2010-12-15 22:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 0:28 [PATCH V6 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver tmarri
2010-12-09 6:47 ` Greg KH
2010-12-09 16:45 ` Tirumala Marri
2010-12-09 16:47 ` Tirumala Marri
2010-12-10 4:52 ` Alexander Gordeev
2010-12-10 6:21 ` Tirumala Marri
2010-12-10 22:44 ` Greg KH
2010-12-11 17:53 ` Tirumala Marri
2010-12-13 15:48 ` Neil Jones
2010-12-15 10:17 ` Neil Jones
2010-12-15 22:50 ` Tirumala Marri [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-09 0:16 tmarri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTim4nh-9mL=ziAKbcRa2kZnoQk0pinREZ0qMYuqN@mail.gmail.com' \
--to=tmarri@apm.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=neiljay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).