From: Grant Likely <grant.likely@secretlab.ca>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: "Stephen Rothwell" <sfr@canb.auug.org.au>,
"Daniel Walker" <dwalker@codeaurora.org>,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
linux-kbuild@vger.kernel.org, "Tony Lindgren" <tony@atomide.com>,
"Nicolas Pitre" <nico@fluxnic.net>,
lkml <linux-kernel@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig
Date: Fri, 16 Jul 2010 14:17:05 -0600 [thread overview]
Message-ID: <AANLkTimKpmZaGRYfYs8HGDz-_VG8ePXN6bZvl2-YcNdR@mail.gmail.com> (raw)
In-Reply-To: <1279310976.18579.8.camel@e102109-lin.cambridge.arm.com>
On Fri, Jul 16, 2010 at 2:09 PM, Catalin Marinas
<catalin.marinas@arm.com> wrote:
> On Fri, 2010-07-16 at 19:46 +0100, Linus Torvalds wrote:
>> On Fri, Jul 16, 2010 at 11:40 AM, Nicolas Pitre <nico@fluxnic.net> wrote=
:
>> >
>> > DOH.
>>
>> Well, it's possible that the correct approach is a mixture.
>>
>> Automatically do the trivial cases (recursive selects, dependencies
>> that are simple or of the form "x && y" etc), and warn about the cases
>> that aren't trivial (where "not trivial" may not necessarily be about
>> fundamentally ambiguous ones, but just "complex enough that I won't
>> even try").
>
> There is still a risk with this approach when the Kconfig isn't entirely
> correct. For example, on ARM we have (I pushed a patch already):
>
> config CPU_32v6K
> =A0 =A0 =A0 =A0depends on CPU_V6
>
> config CPU_V7
> =A0 =A0 =A0 =A0select CPU_32v6K
>
> In this simple approach, we end up selecting CPU_V6 when we only need
> CPU_V7. There other places like this in the kernel.
>
> Of course, kbuild could still warn but if people rely on this feature to
> select options automatically I suspect they would ignore the warnings.
In my first patch, I made Kconfig problems errors instead of warnings.
That would prevent people from ignoring them.
g.
next prev parent reply other threads:[~2010-07-16 20:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 23:04 [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig Grant Likely
2010-07-13 23:11 ` Grant Likely
2010-07-13 23:14 ` Daniel Walker
2010-07-13 23:21 ` Grant Likely
2010-07-13 23:33 ` Daniel Walker
2010-07-14 0:07 ` Nicolas Pitre
2010-07-14 16:22 ` Daniel Walker
2010-07-16 23:49 ` Jamie Lokier
2010-07-19 5:20 ` Grant Likely
2010-07-16 16:03 ` Catalin Marinas
2010-07-16 17:57 ` Grant Likely
2010-07-16 18:07 ` Russell King - ARM Linux
2010-07-16 18:17 ` Linus Torvalds
2010-07-16 18:18 ` Grant Likely
2010-07-16 18:19 ` Nicolas Pitre
2010-07-16 18:21 ` Grant Likely
2010-07-16 18:31 ` Nicolas Pitre
2010-07-16 18:30 ` Russell King - ARM Linux
2010-07-16 18:40 ` Nicolas Pitre
2010-07-16 18:46 ` Linus Torvalds
2010-07-16 20:09 ` Catalin Marinas
2010-07-16 20:17 ` Grant Likely [this message]
2010-07-16 20:29 ` Nicolas Pitre
2010-07-16 20:37 ` Grant Likely
2010-07-16 20:44 ` Catalin Marinas
2010-07-16 20:11 ` Arnd Bergmann
2010-07-16 18:52 ` Grant Likely
2010-07-16 20:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimKpmZaGRYfYs8HGDz-_VG8ePXN6bZvl2-YcNdR@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=catalin.marinas@arm.com \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nico@fluxnic.net \
--cc=sfr@canb.auug.org.au \
--cc=tony@atomide.com \
--cc=torvalds@linux-foundation.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).