From: Stijn Devriendt <highguy@gmail.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org
Subject: Re: [PATCH 1/3] misc: at24: parse OF-data, too
Date: Mon, 22 Nov 2010 17:48:40 +0100 [thread overview]
Message-ID: <AANLkTimv5JsqAZ-AGM23N_cm6-BXB7wtcmS_xiYBZ55r@mail.gmail.com> (raw)
In-Reply-To: <20101120124226.GB11936@pengutronix.de>
Hi Wolfram,
I seem to be mistaken. I retried "compatible=3D<linux,24c64>" and it did
all the right
things. I was mistaken that request_module() only takes the driver
name, at24 in this
case, and not all device names in the table_ids.
This pretty much makes my patch redundant. Thanks for helping me clear
things out.
Regards,
Stijn
On Sat, Nov 20, 2010 at 1:42 PM, Wolfram Sang <w.sang@pengutronix.de> wrote=
:
> Hi,
>
>> As far as I could tell, using compatible =3D <24c64>; didn't load the ri=
ght
>> module (module name is at24) and using at24 caused a device id mismatch
>> because at24 is not a known device ID. I could be wrong here and if so, =
I'd
>> very =A0much like a source code hint as to why...
>
> Have you tried "<vendor>, 24c64"? All I can say is that it works for me. =
Plain
> at24 worked for years with pcm030.dts and pcm032.dts, so I don't know whi=
ch
> issue you are facing. This patch is just about extending the support.
>
>> My patch worked by changing drivers/of/of_i2c.c to allow a generic
>> kind =3D " " statement that was filled in as i2c_board_info.type, to all=
ow
>> the module name and the device id to be different.
>> This makes the at24 driver no longer rely on probing (which it claims
>> is buggy anyway) and also benefits other drivers that support multiple
>> devices, but where probing is difficult (e.g. lm90 driver).
>>
>> I'm in the process of getting employer approval to get these patches
>> upstream.
>
> I hope you will get it approved, it is a lot easier to talk about code :)
>
> Best regards,
>
> =A0 Wolfram
>
> --
> Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | Wo=
lfram Sang =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0|
> Industrial Linux Solutions =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | http://www.p=
engutronix.de/ =A0|
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkznwjIACgkQD27XaX1/VRssnwCgg55UCwZFLcMI8kJI3mhCJQxL
> N7kAoJHpLn5BJpNjET+ngaQFrGxUBQm1
> =3DtyTb
> -----END PGP SIGNATURE-----
>
>
next prev parent reply other threads:[~2010-11-22 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 12:00 [PATCH V2 0/3] at24: parse OF-data Wolfram Sang
2010-11-17 12:00 ` [PATCH 1/3] misc: at24: parse OF-data, too Wolfram Sang
2010-11-20 10:54 ` Stijn Devriendt
2010-11-20 12:42 ` Wolfram Sang
2010-11-20 14:07 ` Stijn Devriendt
2010-11-22 16:48 ` Stijn Devriendt [this message]
2010-12-24 9:15 ` Grant Likely
2010-11-17 12:00 ` [PATCH 2/3] misc: at24: add more sanity checks for parameters Wolfram Sang
2010-12-24 9:15 ` Grant Likely
2010-11-17 12:00 ` [PATCH 3/3] powerpc: pcm030/032: add pagesize to dts Wolfram Sang
2010-12-24 9:15 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimv5JsqAZ-AGM23N_cm6-BXB7wtcmS_xiYBZ55r@mail.gmail.com \
--to=highguy@gmail.com \
--cc=devicetree-discuss@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).