From: Kyle Moffett <kyle@moffetthome.net>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org, linuxppc-dev@ozlabs.org,
Liu Yu <yu.liu@freescale.com>,
linux-kernel@vger.kernel.org,
Kyle Moffett <Kyle.D.Moffett@boeing.com>
Subject: Re: [PATCH] powerpc/kvm/e500_tlb: Fix a minor copy-paste tracing bug
Date: Sat, 28 Aug 2010 01:24:14 -0400 [thread overview]
Message-ID: <AANLkTimwBL42bAxa5okPeJ-y_oSCfp05_POxxRasZGFn@mail.gmail.com> (raw)
In-Reply-To: <B3286B71-599C-405E-847F-06B843A46449@suse.de>
On Fri, Aug 27, 2010 at 20:58, Alexander Graf <agraf@suse.de> wrote:
> On 27.08.2010, at 21:06, Kyle Moffett wrote:
>> The kvmppc_e500_stlbe_invalidate() function was trying to pass too many
>> parameters to trace_kvm_stlb_inval(). =C2=A0This appears to be a bad
>> copy-paste from a call to trace_kvm_stlb_write().
>
> Which kernel is this against? That trace point is already commented out i=
n my tree.
Oh, hm, I guess I haven't rebased this patch since 2.6.35-ish. The
trace point seems to work correctly with the fixed arguments; if
you'll tell me which tree I should base it on I can easily resubmit.
Cheers,
Kyle Moffett
next prev parent reply other threads:[~2010-08-28 5:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 19:06 [PATCH] powerpc/kvm/e500_tlb: Fix a minor copy-paste tracing bug Kyle Moffett
2010-08-28 0:58 ` Alexander Graf
2010-08-28 5:24 ` Kyle Moffett [this message]
2010-08-28 10:51 ` Alexander Graf
2010-08-30 15:38 ` Kyle Moffett
2010-08-31 1:07 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimwBL42bAxa5okPeJ-y_oSCfp05_POxxRasZGFn@mail.gmail.com \
--to=kyle@moffetthome.net \
--cc=Kyle.D.Moffett@boeing.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=yu.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).