From: Grant Likely <grant.likely@secretlab.ca>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Michal Simek <monstr@monstr.eu>,
microblaze-uclinux@itee.uq.edu.au,
linuxppc-dev <linuxppc-dev@ozlabs.org>,
sparclinux@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH 0/2] Replace of_device with platform_device
Date: Thu, 10 Jun 2010 21:08:37 -0600 [thread overview]
Message-ID: <AANLkTinVTGV32OfFaEp-zJpHtOWFHOvWPgxtxxocY2Du@mail.gmail.com> (raw)
In-Reply-To: <1276218990.1962.81.camel@pasglop>
On Thu, Jun 10, 2010 at 7:16 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Thu, 2010-06-10 at 10:46 -0600, Grant Likely wrote:
>>
>> It shouldn't need any fixing because I'm not touching the driver side
>> of the equation (unlike the last breakage where macio_driver had its
>> own copy of the match table which I missed). =A0In fact, there aren't
>> even any logic changes other than dealing with moving some of the
>> structure members in the sparc arch code. =A0If I did miss anything,
>> then it should show up in build testing.
>
> Ok, but I though you were actually replacing occurences of "of_device"
> with "platform_device", and so was wondering why you aren't changing the
> ones in macio. But yes, the #define you did might do the trick as long
> as the resources are still named the same etc...
I will, but it is a big job, so the #define lets me do it in chunks.
I made sure the member names in of_device were identical to
platform_device so that it works as a drop-in.
g.
prev parent reply other threads:[~2010-06-11 3:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100604205930.2762.17131.stgit@angua>
2010-06-04 21:11 ` [PATCH 2/2] of: kill struct of_device Grant Likely
2010-06-16 21:07 ` David Miller
2010-06-04 21:13 ` [PATCH 0/2] Replace of_device with platform_device Grant Likely
2010-06-10 6:32 ` Benjamin Herrenschmidt
2010-06-10 16:46 ` Grant Likely
2010-06-11 1:16 ` Benjamin Herrenschmidt
2010-06-11 3:08 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinVTGV32OfFaEp-zJpHtOWFHOvWPgxtxxocY2Du@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).