From: Kumar Gala <galak@kernel.crashing.org>
To: Nathael Pajani <nathael.pajani@cpe.fr>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] powerpc: CPM2 interrupt handler failure after 100,000
Date: Mon, 19 Dec 2005 09:18:05 -0600 [thread overview]
Message-ID: <AD798914-F1FD-4143-A312-D31BE12B1188@kernel.crashing.org> (raw)
In-Reply-To: <20051219085747.5D79425C7AA@smtp-out.completel.net>
On Dec 19, 2005, at 3:00 AM, Nathael Pajani wrote:
> interrupts
> Message-Id: <20051219100059.5a95533f.nathael.pajani@cpe.fr>
> X-Mailer: Sylpheed version 2.0.4 (GTK+ 2.8.9; i486-pc-linux-gnu)
> Mime-Version: 1.0
> Content-Type: text/plain; charset=ISO-8859-1
> Content-Transfer-Encoding: quoted-printable
>
> Hi!
>
> Hum.. in the patch you moved from "void" to "int":
>> -static void cpm2_cascade(int irq, void *dev_id, struct pt_regs
>> *regs)
>> +static int cpm2_cascade(int irq, void *dev_id, struct pt_regs *regs)
>
> But should'nt it be "irqreturn_t" ?
> static irqreturn_t cpm2_cascade(int irq, void *dev_id, struct
> pt_regs *regs)
Yep, should be. I'll fixup the patch and resend.
- kumar
prev parent reply other threads:[~2005-12-19 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-19 9:00 [PATCH] powerpc: CPM2 interrupt handler failure after 100,000 Nathael Pajani
2005-12-19 15:18 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AD798914-F1FD-4143-A312-D31BE12B1188@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=nathael.pajani@cpe.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox