[PATCH] aty128fb.c

[PATCH] aty128fb.c

[Jeramy B. Smith]

http://penguinppc.org/projects/jeramy/aty128fb.c.diff

This removes a block of cruft leftover from the iMac days and sets the
default resolution for aty128fb on PPCs to 640x480-60 (ensuring even the
cruddiest of monitors will work).

-jeramy


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: [PATCH] aty128fb.c

[Bastien Nocera]

Quoting "Jeramy B. Smith" <jeramy@penguinppc.org>:

>
> http://penguinppc.org/projects/jeramy/aty128fb.c.diff
>
> This removes a block of cruft leftover from the iMac days and sets the
> default resolution for aty128fb on PPCs to 640x480-60 (ensuring even
> the
> cruddiest of monitors will work).

The iBook2 doesn't support 640x480 afaik

/Bastien Nocera
http://hadess.net

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: [PATCH] aty128fb.c

[Adrian Cox]

Bastien Nocera wrote:

> Quoting "Jeramy B. Smith" <jeramy@penguinppc.org>:
>>This removes a block of cruft leftover from the iMac days and sets the
>>default resolution for aty128fb on PPCs to 640x480-60 (ensuring even
>>the
>>cruddiest of monitors will work).
> The iBook2 doesn't support 640x480 afaik


That should be dealt with by these lines:

	    /* PowerBook Firewire (Pismo), iBook Dual USB */
	    if (machine_is_compatible("PowerBook3,1") ||
	    	machine_is_compatible("PowerBook4,1"))
		default_vmode = VMODE_1024_768_60;


--
Adrian Cox   http://www.humboldt.co.uk/


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: [PATCH] aty128fb.c

[Bastien Nocera]

Quoting Adrian Cox <adrian@humboldt.co.uk>:

>
> Bastien Nocera wrote:
>
> > Quoting "Jeramy B. Smith" <jeramy@penguinppc.org>:
> >>This removes a block of cruft leftover from the iMac days and sets
> the
> >>default resolution for aty128fb on PPCs to 640x480-60 (ensuring even
> >>the
> >>cruddiest of monitors will work).
> > The iBook2 doesn't support 640x480 afaik
>
>
> That should be dealt with by these lines:
>
> 	    /* PowerBook Firewire (Pismo), iBook Dual USB */
> 	    if (machine_is_compatible("PowerBook3,1") ||
> 	    	machine_is_compatible("PowerBook4,1"))
> 		default_vmode = VMODE_1024_768_60;

Hmm, is that already in the sources ?
I'm sorry, I only read the patch, and I'm a bit tired as well.

Thanks for pointing me out

/Bastien Nocera
http://hadess.net

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: [PATCH] aty128fb.c

[k]

on 11/9/01 2:25 AM, Bastien Nocera at hadess@hadess.net wrote:

>
> Quoting "Jeramy B. Smith" <jeramy@penguinppc.org>:
>
>>
>> http://penguinppc.org/projects/jeramy/aty128fb.c.diff
>>
>> This removes a block of cruft leftover from the iMac days and sets the
>> default resolution for aty128fb on PPCs to 640x480-60 (ensuring even
>> the
>> cruddiest of monitors will work).
>
> The iBook2 doesn't support 640x480 afaik
>
> /Bastien Nocera
> http://hadess.net
>
>
>
>

Not to mention my ancient Sony 19" 1024x768/60Hz fixed frequency monitor...
i guess free hardware always has pitfalls ;-)


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: [PATCH] aty128fb.c

[jeramy b smith]

Holger Bettag <hobold@Informatik.Uni-Bremen.DE> wrote:

>"Jeramy B. Smith" <jeramy@penguinppc.org> writes:
>
>>
>> http://penguinppc.org/projects/jeramy/aty128fb.c.diff
>>
>> This removes a block of cruft leftover from the iMac days and sets the
>> default resolution for aty128fb on PPCs to 640x480-60 (ensuring even the
>> cruddiest of monitors will work).
>>
>Cinema Displays can only sync to their native mode. (Not that many of them
>were out there, but...)
>
>  Holger
>

We look for monitor sense values for the cinema display. That's elsewhere in the driver. The way aty128fb sets the default res is like this with my patch:

it looks at machine specific vmodes (powerbook, imac)
it looks at monitor sense info
it looks at user specified vmode args and checks to make sure they are sane
if all of that fails, it uses the aforementioned default
Even if we don't want 640x480 as the default, we dont have to set it with that first hunk I removed, there is another place later in the driver to set the default. I removed the big hunk just as a way to say 'lets be clear about where we set the default res'.

--
-jeramy b smith


"Linux is Fun!" -Linus Torvalds


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: [PATCH] aty128fb.c

[Benjamin Herrenschmidt]

>We look for monitor sense values for the cinema display. That's elsewhere
>in the driver. The way aty128fb sets the default res is like this with my
>patch:
>
>it looks at machine specific vmodes (powerbook, imac)
>it looks at monitor sense info
>it looks at user specified vmode args and checks to make sure they are sane
>if all of that fails, it uses the aforementioned default
>Even if we don't want 640x480 as the default, we dont have to set it with
>that first hunk I removed, there is another place later in the driver to
>set the default. I removed the big hunk just as a way to say 'lets be
>clear about where we set the default res'.

One problem is that monitor sense values are only for Apple old-style
sensing. We need some DDC code in the fbdevs to do that properly.

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/