From: Kumar Gala <galak@kernel.crashing.org>
To: Nye Liu <nyet@mrv.com>
Cc: scottwood@freescale.com, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc
Date: Wed, 2 Jul 2008 02:37:09 -0500 [thread overview]
Message-ID: <B953B5BE-BB24-4656-9F13-7A8228D893E3@kernel.crashing.org> (raw)
In-Reply-To: <20080627200100.GA16661@mrv.com>
On Jun 27, 2008, at 3:01 PM, Nye Liu wrote:
> From: Nye Liu <nyet@mrv.com>
>
> udbg_putc is a *function pointer* that is initialized during
> udbg_init_cpm. It might not be initialized properly when called from
> udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly.
>
> Printing an "X" on initialization is ugly. How about a "\n" instead?
>
> Signed-off-by: Nye Liu <nyet@mrv.com>
>
> ---
Applied. I removed the "\n" per Scott's feedback.
- k
prev parent reply other threads:[~2008-07-02 7:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 20:01 [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc Nye Liu
2008-06-27 20:11 ` Scott Wood
2008-07-02 7:37 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B953B5BE-BB24-4656-9F13-7A8228D893E3@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=nyet@mrv.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).