From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 3/4] powerpc/mpic: Move internal interrupt source vector allocation to a separate function. Mime-Version: 1.0 (Apple Message framework v1257) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: Date: Tue, 27 Mar 2012 09:02:05 -0500 Message-Id: References: <1332850586-23610-1-git-send-email-Varun.Sethi@freescale.com> <84A55A49-747D-4C87-9E5C-E5C63C0CEDA7@kernel.crashing.org> To: Sethi Varun-B16395 Cc: "Linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mar 27, 2012, at 8:52 AM, Sethi Varun-B16395 wrote: >=20 >=20 >> -----Original Message----- >> From: Kumar Gala [mailto:galak@kernel.crashing.org] >> Sent: Tuesday, March 27, 2012 6:55 PM >> To: Sethi Varun-B16395 >> Cc: Linuxppc-dev@lists.ozlabs.org >> Subject: Re: [PATCH 3/4] powerpc/mpic: Move internal interrupt source >> vector allocation to a separate function. >>=20 >>=20 >> On Mar 27, 2012, at 7:16 AM, Varun Sethi wrote: >>=20 >>> Allocate vector numbers for MPIC internal interrupt sources (IPIs = and >>> Timers) in a separate function. >>>=20 >>=20 >> Explain why you are making this change. >=20 >=20 > [Sethi Varun-B16395] With the current code it becomes fairly difficult = to > add new internal interrupt sources. In my case I had to add 32 = additional > interrupt sources corresponding to the MPIC error interrupts. It's = more > convenient doing the internal interrupt source allocation using a = loop. I think that is more due to how you added the MPIC error interrupts and = issues w/that code. If you are treating the MPIC error interrupts as a = cascade than they should have a distinct linux IRQ space from the = standard MPIC interrupts. This is how the MSIs work (as an example). - k=