From: Olof Johansson <olof@lixom.net>
To: Michael Ellerman <michael@ozlabs.org>
Cc: Jimi Xenidis <jimix@watson.ibm.com>,
jack@codezen.org, kumar.gala@freescale.com, imunsie@au.ibm.com,
linuxppc-dev@ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 10/15] powerpc: Define slb0_limit() for BOOK3E
Date: Sat, 16 Apr 2011 22:58:09 -0700 [thread overview]
Message-ID: <BANLkTik+_mRdG5trNfCDCmkxyX3e_WvHGg@mail.gmail.com> (raw)
In-Reply-To: <021a5af117537ce9f7c6c3b27310f15851ab5034.1302856271.git.michael@ellerman.id.au>
Hi,
On Fri, Apr 15, 2011 at 1:32 AM, Michael Ellerman <michael@ozlabs.org> wrot=
e:
> From: Michael Ellerman <michael@ellerman.id.au>
>
> On BOOK3E we don't have an SLB 0, but the equivalent concept is the
> bolted entry mapping the kernel. Currently this is a 1G entry, so
> for now hardcode that. This will probably need to be reworked in
> future.
A year from now when someone sees the ifdef, the above comment would
be nice to have in the code instead of running a git annotate/log to
find out why it's hardcoded the way it is. :)
-Olof
>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> ---
> =A0arch/powerpc/kernel/setup_64.c | =A0 =A04 ++++
> =A01 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_6=
4.c
> index 91a5cc5..3d0daf4 100644
> --- a/arch/powerpc/kernel/setup_64.c
> +++ b/arch/powerpc/kernel/setup_64.c
> @@ -436,10 +436,14 @@ void __init setup_system(void)
>
> =A0static u64 slb0_limit(void)
> =A0{
> +#ifdef CONFIG_PPC_BOOK3E
> + =A0 =A0 =A0 return 1 << 30;
> +#else
> =A0 =A0 =A0 =A0if (cpu_has_feature(CPU_FTR_1T_SEGMENT)) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return 1UL << SID_SHIFT_1T;
> =A0 =A0 =A0 =A0}
> =A0 =A0 =A0 =A0return 1UL << SID_SHIFT;
> +#endif
> =A0}
>
> =A0static void __init irqstack_early_init(void)
> --
> 1.7.1
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
next prev parent reply other threads:[~2011-04-17 5:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 8:31 [PATCH 01/15] powerpc/a2: Add some #defines for A2 specific instructions Michael Ellerman
2011-04-15 8:31 ` [PATCH 02/15] of: Export of_irq_find_parent() Michael Ellerman
2011-04-15 8:31 ` [PATCH 04/15] powerpc/xics: xics.h relies on linux/interrupt.h Michael Ellerman
2011-04-15 8:31 ` [PATCH 03/15] powerpc: Add SCOM infrastructure Michael Ellerman
2011-04-15 8:31 ` [PATCH 05/15] powerpc/xics: Move irq_host matching into the ics backend Michael Ellerman
2011-04-15 8:32 ` [PATCH 06/15] powerpc/nvram: Search for nvram using compatible Michael Ellerman
2011-04-15 8:32 ` [PATCH 07/15] powerpc: Move CPU_FTRS_BASE_BOOK3E into cputable.h & update FTR masks Michael Ellerman
2011-04-18 12:37 ` Kumar Gala
2011-04-15 8:32 ` [PATCH 08/15] powerpc: Add A2 cpu support Michael Ellerman
2011-04-15 8:32 ` [PATCH 09/15] powerpc: Add TLB size detection for TYPE_3E MMUs Michael Ellerman
2011-04-15 8:32 ` [PATCH 10/15] powerpc: Define slb0_limit() for BOOK3E Michael Ellerman
2011-04-17 5:58 ` Olof Johansson [this message]
2011-04-18 12:42 ` Kumar Gala
2011-04-18 21:41 ` Benjamin Herrenschmidt
2011-04-18 22:30 ` Kumar Gala
2011-04-18 22:50 ` Benjamin Herrenschmidt
2011-04-15 8:32 ` [PATCH 12/15] powerpc/book3e: Use way 3 for linear mapping bolted entry Michael Ellerman
2011-04-18 12:43 ` Kumar Gala
2011-04-18 21:40 ` Benjamin Herrenschmidt
2011-04-18 22:27 ` Kumar Gala
2011-04-18 22:44 ` Benjamin Herrenschmidt
2011-04-15 8:32 ` [PATCH 11/15] powerpc: Index crit/dbg/mcheck stacks using cpu number on 64bit Michael Ellerman
2011-04-15 8:32 ` [PATCH 13/15] powerpc/book3e: Flush IPROT protected TLB entries leftover by firmware Michael Ellerman
2011-04-15 8:32 ` [PATCH 14/15] powerpc: Add WSP platform Michael Ellerman
2011-04-18 12:46 ` Kumar Gala
2011-04-18 21:39 ` Benjamin Herrenschmidt
2011-04-15 8:32 ` [PATCH 15/15] powerpc: Add early debug for WSP platforms Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTik+_mRdG5trNfCDCmkxyX3e_WvHGg@mail.gmail.com \
--to=olof@lixom.net \
--cc=david@gibson.dropbear.id.au \
--cc=imunsie@au.ibm.com \
--cc=jack@codezen.org \
--cc=jimix@watson.ibm.com \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).