From: Grant Likely <grant.likely@secretlab.ca>
To: "Ira W. Snyder" <iws@ovro.caltech.edu>
Cc: Linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: platform_driver/of_platform_driver compile warning in fsldma.c
Date: Fri, 8 Apr 2011 09:56:45 -0700 [thread overview]
Message-ID: <BANLkTikJzhY9=p9NkCovHgQA0YtfYBMuSw@mail.gmail.com> (raw)
In-Reply-To: <20110408153246.GA13834@ovro.caltech.edu>
On Fri, Apr 8, 2011 at 8:32 AM, Ira W. Snyder <iws@ovro.caltech.edu> wrote:
> On Fri, Apr 08, 2011 at 04:12:13AM -0500, Kumar Gala wrote:
>> Grant,
>>
>> I'm being lazy, can you give any quick insight on the following compile warning:
>>
>> drivers/dma/fsldma.c:1457:2: warning: initialization from incompatible pointer type
>> drivers/dma/fsldma.c: In function 'fsldma_init':
>> drivers/dma/fsldma.c:1468:2: warning: passing argument 1 of 'platform_driver_register' from incompatible pointer type
>> include/linux/platform_device.h:124:12: note: expected 'struct platform_driver *' but argument is of type 'struct of_platform_driver *'
>> drivers/dma/fsldma.c: In function 'fsldma_exit':
>> drivers/dma/fsldma.c:1473:2: warning: passing argument 1 of 'platform_driver_unregister' from incompatible pointer type
>> include/linux/platform_device.h:125:13: note: expected 'struct platform_driver *' but argument is of type 'struct of_platform_driver *'
>>
>
> The "struct of_platform_driver" needs to be changed to a
> "struct platform_driver". Just remove the "of_" prefix, the structure
> initialization is correct. I sent a patch for this yesterday to LKML. The
> title is: fsldma: fix build warning caused by of_platform_device changes
Yes, thanks Ira. I'm picking up that patch today and I'll send it off to Linus.
g.
next prev parent reply other threads:[~2011-04-08 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 9:12 platform_driver/of_platform_driver compile warning in fsldma.c Kumar Gala
2011-04-08 15:32 ` Ira W. Snyder
2011-04-08 16:56 ` Grant Likely [this message]
2011-04-09 14:40 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikJzhY9=p9NkCovHgQA0YtfYBMuSw@mail.gmail.com' \
--to=grant.likely@secretlab.ca \
--cc=iws@ovro.caltech.edu \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).