From: Bjorn Helgaas <bhelgaas@google.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-arch@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [RFC/PATCH] of: Match PCI devices to OF nodes generically
Date: Mon, 4 Apr 2011 09:25:20 -0600 [thread overview]
Message-ID: <BANLkTimBD=NfFKGpy0ZTnT9Dcu=dkTHxZg@mail.gmail.com> (raw)
In-Reply-To: <1301902664.2549.76.camel@pasglop>
On Mon, Apr 4, 2011 at 1:37 AM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> powerpc has two different ways of matching PCI devices to their
> corresponding OF node (if any) for historical reasons. The ppc64 one
> does a scan looking for matching bus/dev/fn, while the ppc32 one does a
> scan looking only for matching dev/fn on each level in order to be
> agnostic to busses being renumbered (which Linux does on some
> platforms).
>
> This removes both and instead moves the matching code to the PCI core
> itself. It's the most logical place to do it: when a pci_dev is created,
> we know the parent and thus can do a single level scan for the matching
> device_node (if any).
Some of this is reminiscent of the ACPI/PCI binding we do on x86/ia64,
e.g., acpi_get_pci_dev() and the stuff in drivers/acpi/glue.c. Have
you looked at that to see if there's any hope of covering both OF and
ACPI with something more generic?
Bjorn
next prev parent reply other threads:[~2011-04-04 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 2:04 [RFC/PATCH] of: Match PCI devices to OF nodes generically Benjamin Herrenschmidt
2011-04-04 3:27 ` Benjamin Herrenschmidt
2011-04-04 7:37 ` Benjamin Herrenschmidt
2011-04-04 15:25 ` Bjorn Helgaas [this message]
2011-04-04 21:03 ` Benjamin Herrenschmidt
2011-04-04 23:58 ` Benjamin Herrenschmidt
2011-04-05 2:32 ` Grant Likely
2011-04-05 6:42 ` Benjamin Herrenschmidt
2011-04-04 7:48 ` David Miller
2011-04-04 21:03 ` Benjamin Herrenschmidt
2011-04-04 21:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimBD=NfFKGpy0ZTnT9Dcu=dkTHxZg@mail.gmail.com' \
--to=bhelgaas@google.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).