From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 Sender: glikely@secretlab.ca In-Reply-To: References: <20110428192227.8979.49181.stgit@ponder> <1304386999.2513.293.camel@pasglop> <20110504155227.GA3317@ponder.secretlab.ca> <1304555953.2513.390.camel@pasglop> From: Grant Likely Date: Thu, 5 May 2011 08:07:05 -0600 Message-ID: Subject: Re: [PATCH 0/6] General device tree irq domain infrastructure To: Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Cc: Michal Simek , Sebastian Andrzej Siewior , x86@kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , hpa@zytor.com, Dirk Brandewie , linuxppc-dev@lists.ozlabs.org, devicetree-discuss@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, May 5, 2011 at 2:37 AM, Thomas Gleixner wrote: > On Thu, 5 May 2011, Benjamin Herrenschmidt wrote: >> > As for the mapping, I agree that the functionality is generally >> > useful, I'm just not fond of the current implementation. =A0I think it >> > is more complex than it needs to be and I'm not excited about bring it >> > over to the other architectures as-is. >> >> Nobody cares about the current implementation. What is important is >> indeed the functionality. The basic thing I think everybody agrees is >> that you need to extend the irq_desc (or data, whatever tglx prefers) >> with two bits of information: Some identifier of the domain and some >> identifier of the interrupt number within that domain. > > irq_data because that's what is handed into the callbacks and you > probably want to have the HW number there. Okay, I'll take another hack at it. Unfortunately I've got a great big unmaskable interrupt in the form of UDS next week, but I'll be back on it the week after. g.