From: Hitoshi Mitake <h.mitake@gmail.com>
To: "Moore, Eric" <Eric.Moore@lsi.com>
Cc: linux-arch <linux-arch@vger.kernel.org>,
"Prakash, Sathya" <Sathya.Prakash@lsi.com>,
"Desai, Kashyap" <Kashyap.Desai@lsi.com>,
linux scsi dev <linux-scsi@vger.kernel.org>,
Matthew Wilcox <matthew@wil.cx>,
linux powerpc dev <linuxppc-dev@lists.ozlabs.org>,
Milton Miller <miltonm@bga.com>,
linux kernel <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Ingo Molnar <mingo@redhat.com>,
"paulus@samba.org" <paulus@samba.org>,
linux pci <linux-pci@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 1/3] mpt2sas: remove the use of writeq, since writeq is not atomic
Date: Thu, 19 May 2011 13:08:38 +0900 [thread overview]
Message-ID: <BANLkTin4w1QyL1NyTyrZARPWASai45W_4Q@mail.gmail.com> (raw)
In-Reply-To: <4565AEA676113A449269C2F3A549520F80BE7F37@cosmail03.lsi.com>
On Thu, May 19, 2011 at 04:11, Moore, Eric <Eric.Moore@lsi.com> wrote:
> On Wednesday, May 18, 2011 12:31 PM Milton Miller wrote:
>> Ingo I would propose the following commits added in 2.6.29 be reverted.
>> I think the current concensus is drivers must know if the writeq is
>> not atomic so they can provide their own locking or other workaround.
>>
>
>
> Exactly.
>
The original motivation of preparing common readq/writeq is that
letting each driver
have their own readq/writeq is bad for maintenance of source code.
But if you really dislike them, there might be two solutions:
1. changing the name of readq/writeq to readq_nonatomic/writeq_nonatomic
2. adding new C file to somewhere and defining spinlock for them.
With spin_lock_irqsave() and spin_unlock_irqrestore() on the spinlock,
readq/writeq can be atomic.
How do you think about them? If you cannot agree with the above two solutions,
I'll agree with reverting them.
--
Hitoshi Mitake
h.mitake@gmail.com
next prev parent reply other threads:[~2011-05-19 4:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110504115324.GE17855@lsi.com>
[not found] ` <1305616571.6008.23.camel@mulgrave.site>
[not found] ` <B2FD678A64EAAD45B089B123FDFC3ED70157F7BCE5@inbmail01.lsi.com>
2011-05-18 4:15 ` [PATCH 1/3] mpt2sas: remove the use of writeq, since writeq is not atomic Matthew Wilcox
2011-05-18 4:23 ` James Bottomley
2011-05-18 7:00 ` Benjamin Herrenschmidt
2011-05-18 8:23 ` Milton Miller
2011-05-18 15:35 ` Moore, Eric
2011-05-18 18:31 ` Milton Miller
2011-05-18 19:11 ` Moore, Eric
2011-05-19 4:08 ` Hitoshi Mitake [this message]
2011-05-19 4:46 ` James Bottomley
2011-05-19 5:36 ` Benjamin Herrenschmidt
2011-05-19 8:35 ` [PATCH 1/3] mpt2sas: remove the use of writeq, since writeq isnot atomic David Laight
2011-05-19 4:16 ` [PATCH 1/3] mpt2sas: remove the use of writeq, since writeq is not atomic Roland Dreier
2011-05-19 5:34 ` Benjamin Herrenschmidt
2011-05-19 18:15 ` Ingo Molnar
2011-05-18 21:30 ` Benjamin Herrenschmidt
2011-05-18 22:05 ` Moore, Eric
2011-05-18 8:04 ` [PATCH 1/3] mpt2sas: remove the use of writeq, since writeq isnot atomic David Laight
2011-05-18 5:45 ` [PATCH 1/3] mpt2sas: remove the use of writeq, since writeq is not atomic Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTin4w1QyL1NyTyrZARPWASai45W_4Q@mail.gmail.com \
--to=h.mitake@gmail.com \
--cc=Eric.Moore@lsi.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Kashyap.Desai@lsi.com \
--cc=Sathya.Prakash@lsi.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthew@wil.cx \
--cc=miltonm@bga.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).