From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bay0-omc3-s41.bay0.hotmail.com (bay0-omc3-s41.bay0.hotmail.com [65.54.246.241]) by ozlabs.org (Postfix) with ESMTP id 5CC68DDDFC for ; Thu, 3 Apr 2008 19:28:54 +1100 (EST) Message-ID: Content-Type: multipart/alternative; boundary="_1b3bec81-453b-4902-ae11-0a52fa7824be_" From: MingLiu To: John Bonesio , Johann Baudy Subject: RE: Xilinx LLTEMAC driver issues Date: Thu, 3 Apr 2008 08:28:53 +0000 In-Reply-To: <20080403003200.CB2BF1968046@mail103-sin.bigfish.com> References: <20080329125416.B09261AD8051@mail119-sin.bigfish.com> <000601c8931f$e1d549a0$a57fdce0$@se> <7e0dd21a0804020020s66a091ferfbbf4142adcd84ae@mail.gmail.com> <20080403003200.CB2BF1968046@mail103-sin.bigfish.com> MIME-Version: 1.0 Cc: John Linn , git , linuxppc-embedded@ozlabs.org List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --_1b3bec81-453b-4902-ae11-0a52fa7824be_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: 8bit Dear all, > The change with the extra parenthesis (in the patch starting with line 133) seems unecessary. I looked at the XLlDma_mBdWrite macro and it appeared to have the correct use of parethesis in the implementation.> So, assuming there's nothing subtle that I missed, it's not needed. However, it does no harm either. However it really helps after I tried this patch. So there should be some difference after it is used. One more question, does this mean that the problem is not on the hardware timing, but the device driver? BR Ming _________________________________________________________________ 用手机MSN聊天写邮件看空间，无限沟通，分享精彩！ http://mobile.msn.com.cn/ --_1b3bec81-453b-4902-ae11-0a52fa7824be_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: 8bit Dear all,

> The change with the extra parenthesis (in the patch starting with line 133) seems unecessary. I looked at the XLlDma_mBdWrite macro and it appeared to have the correct use of parethesis in the implementation.
> So, assuming there's nothing subtle that I missed, it's not needed. However, it does no harm either.

However it really helps after I tried this patch. So there should be some difference after it is used.

One more question, does this mean that the problem is not on the hardware timing, but the device driver?

BR
Ming

Windows Live Writer，支持离线撰写博客内容，随时随地想写就写。立即使用！ --_1b3bec81-453b-4902-ae11-0a52fa7824be_--