From: Kumar Gala <kumar.gala@freescale.com>
To: "Eugene Surovegin" <ebs@ebshome.net>
Cc: Kumar Gala <galak@somerset.sps.mot.com>, linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH][PPC32] Added MPC8555/8541 security block infrastructure
Date: Tue, 9 Nov 2004 00:15:20 -0600 [thread overview]
Message-ID: <BB7A072F-3216-11D9-89A0-000393DBC2E8@freescale.com> (raw)
In-Reply-To: <20041109060109.GA26831@gate.ebshome.net>
> > diff -Nru a/include/asm-ppc/mpc85xx.h b/include/asm-ppc/mpc85xx.h
> > --- a/include/asm-ppc/mpc85xx.h=A0=A0=A0=A0=A0=A0 2004-11-08 =
21:33:21 -06:00
> > +++ b/include/asm-ppc/mpc85xx.h=A0=A0=A0=A0=A0=A0 2004-11-08 =
21:33:21 -06:00
> > @@ -81,6 +81,7 @@
> >=A0 #define MPC85xx_IRQ_DUART=A0=A0=A0 (26 + =
MPC85xx_OPENPIC_IRQ_OFFSET)
> >=A0 #define MPC85xx_IRQ_IIC1=A0=A0=A0=A0 (27 + =
MPC85xx_OPENPIC_IRQ_OFFSET)
> >=A0 #define MPC85xx_IRQ_PERFMON=A0 (28 + MPC85xx_OPENPIC_IRQ_OFFSET)
> > +#define MPC85xx_IRQ_SEC2=A0=A0=A0=A0 (29 + =
MPC85xx_OPENPIC_IRQ_OFFSET)
> >=A0 #define MPC85xx_IRQ_CPM=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 (30 =
+=20
> MPC85xx_OPENPIC_IRQ_OFFSET)
> >
> >=A0 /* The 12 external interrupt lines */
> > @@ -120,6 +121,8 @@
> >=A0 #define MPC85xx_PCI2_SIZE=A0=A0=A0 (0x01000)
> >=A0 #define MPC85xx_PERFMON_OFFSET=A0=A0=A0=A0=A0=A0 (0xe1000)
> >=A0 #define MPC85xx_PERFMON_SIZE (0x01000)
> > +#define MPC85xx_SEC2_OFFSET=A0 (0x30000)
> > +#define MPC85xx_SEC2_SIZE=A0=A0=A0 (0x10000)
> >=A0 #define MPC85xx_UART0_OFFSET (0x04500)
> >=A0 #define MPC85xx_UART0_SIZE=A0=A0 (0x00100)
> >=A0 #define MPC85xx_UART1_OFFSET (0x04600)
> > diff -Nru a/include/asm-ppc/ocp_ids.h b/include/asm-ppc/ocp_ids.h
> > --- a/include/asm-ppc/ocp_ids.h=A0=A0=A0=A0=A0=A0 2004-11-08 =
21:33:21 -06:00
> > +++ b/include/asm-ppc/ocp_ids.h=A0=A0=A0=A0=A0=A0 2004-11-08 =
21:33:21 -06:00
> > @@ -61,6 +61,7 @@
> >=A0 #define OCP_FUNC_PERFMON=A0=A0=A0=A0 0x00D2=A0 /* Performance =
Monitor */
> >=A0 #define OCP_FUNC_RGMII=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 =
0x00D3
> >=A0 #define OCP_FUNC_TAH =A0=A0=A0=A0=A0=A0=A0 0x00D4
> > +#define OCP_FUNC_SEC2=A0=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 =
0x00D5=A0 /* Crypto/Security=20
> 2.0 */
> >
> >=A0 /* Network 0x0200 - 0x02FF */
> >=A0 #define OCP_FUNC_EMAC=A0=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 =
0x0200
>
> I wonder what is the purpose of adding these defines to the header =
file
> and then using them only in one .c file. Are they public interface?
>
> I guess not, and IMHO scattering such stuff among doesn't help
> readability and using new C structure initializers shows exactly what
> each number means anyway.
Well, the SEC2 defines are currently only used in this file at this=20
time. However, I expect in the future other mpc85??.c files will use=20
these defines.
> For 4xx, for example, we moved all such stuff directly to
> corresponding ibm4XXX files.
The memory offsets and sizes could most likely move there.
- kumar
prev parent reply other threads:[~2004-11-09 6:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-09 5:25 [PATCH][PPC32] Added MPC8555/8541 security block infrastructure Kumar Gala
2004-11-09 5:34 ` Andrew Morton
2004-11-09 5:48 ` Kumar Gala
2004-11-09 5:54 ` Andrew Morton
2004-11-09 9:12 ` Geert Uytterhoeven
2004-11-09 6:01 ` Eugene Surovegin
2004-11-09 6:15 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BB7A072F-3216-11D9-89A0-000393DBC2E8@freescale.com \
--to=kumar.gala@freescale.com \
--cc=ebs@ebshome.net \
--cc=galak@somerset.sps.mot.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox