LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: Benjamin Krill <ben@codiert.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: change to of MTD partition parsing
Date: Mon, 24 Aug 2009 21:04:53 -0500	[thread overview]
Message-ID: <BF5D9DCD-A15E-4E11-B35E-1144B2DF722E@kernel.crashing.org> (raw)
In-Reply-To: <20090812150709.GM14754@codiert.org>

Ben,

We need a better solution to the problem.  What does the device tree  
on SLOF look like?

- k

On Aug 12, 2009, at 10:07 AM, Benjamin Krill wrote:

> Hi Kumar,
>
> slof has a further node inside the flash node which is not a partition
> entry. The old code just used all children and since the further node
> isn't a partition not all needed properties are there.
>
> cheers
> ben
>
>
> * Kumar Gala | 2009-08-12 09:46:10 [-0500]:
>
>> Ben,
>>
>> The following commit breaks the previous definition of flash  
>> partitions according to
>> Documentation/powerpc/dts-bindings/mtd-physmap.txt.  Using the  
>> 'name' field is bad practice.  What was going
>> on w/the SLOF case?
>>
>> - k
>>
>>
>> commit 4b08e149c0e02e97ec49c2a31d14a0d3a02f8074
>> Author: Benjamin Krill <ben@codiert.org>
>> Date:   Fri Jan 23 17:18:05 2009 +0100
>>
>>   [MTD] ofpart: Check name property to determine partition nodes.
>>
>>   SLOF has a further node which could not be evaluated
>>   by the current routine. The current routine returns
>>   because the node hasn't the required reg property. As
>>   fix this patch adds a check to determine the partition
>>   child nodes. If the node is not a partition the number
>>   of total partitions will be decreased and loop continues
>>   with the next nodes.
>>
>>   Signed-off-by: Benjamin Krill <ben@codiert.org>
>>   Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
>>

      parent reply	other threads:[~2009-08-25  2:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-12 14:46 change to of MTD partition parsing Kumar Gala
     [not found] ` <20090812150709.GM14754@codiert.org>
2009-08-25  2:04   ` Kumar Gala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BF5D9DCD-A15E-4E11-B35E-1144B2DF722E@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=ben@codiert.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox