From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id E6332DDE09 for ; Wed, 12 Sep 2007 03:56:36 +1000 (EST) In-Reply-To: <46E6D4D4.2050600@freescale.com> References: <20070911141821.GA32545@lixom.net> <230A7A2A-3184-4BC2-B8AC-C94090B532B0@kernel.crashing.org> <20070911155558.GA10743@lixom.net> <11B85E70-D643-4013-A9B3-59CD76F9D7AB@kernel.crashing.org> <20070911171521.GB10743@lixom.net> <46E6CE9A.8080402@freescale.com> <20070911173308.GA11951@lixom.net> <46E6D4D4.2050600@freescale.com> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: From: Kumar Gala Subject: Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port Date: Tue, 11 Sep 2007 12:59:22 -0500 To: Scott Wood Cc: Olof Johansson , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sep 11, 2007, at 12:48 PM, Scott Wood wrote: > Olof Johansson wrote: >> On Tue, Sep 11, 2007 at 12:21:30PM -0500, Scott Wood wrote: >>> Olof Johansson wrote: >>>> On Tue, Sep 11, 2007 at 11:00:28AM -0500, Kumar Gala wrote: >>>>> well the ifdefs are orthogonal. We don't have a way of knowing >>>>> primary from the device tree today. >>>> How about something like "fsl,primary-phb" in the bus device >>>> node? I don't >>>> know, maybe it's already been discussed and turned down for some >>>> reason. >>> It's more of a Linux issue than anything to do with the hardware. >> >> That doesn't stop firmware from telling linux which bus is the >> primary >> one on the system to help out. > > The entire notion of a "primary" PCI bus is due to a Linux flaw. > > If we did put it in the device tree, it should be something like > "linux,primary-phb". But since Linux can tell from the node's > children, > there doesn't seem to be much point. Once someone rights code to do this I'm happy to change over. I took this model of explicitly knowing the primary PHB from the pmac code. - k