From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8B85C1007D2 for ; Thu, 15 Jul 2010 01:34:36 +1000 (EST) In-Reply-To: <1279120733-13584-1-git-send-email-msm@freescale.com> References: <1279120733-13584-1-git-send-email-msm@freescale.com> Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: From: Segher Boessenkool Subject: Re: [PATCH V4] powerpc/prom: Export device tree physical address via proc Date: Wed, 14 Jul 2010 17:35:43 +0200 To: Matthew McClintock Cc: Kumar Gala , linuxppc-dev@lists.ozlabs.org, Timur Tabi List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > V4: Fixed misspelling Any particular reason you fixed only one of the two mispelings I pointed out? (device tree is two words, not one). > + prop = of_find_property(node, "linux,devicetree-start", NULL); > + if (prop) > + prom_remove_property(node, prop); > + > + prop = of_find_property(node, "linux,devicetree-end", NULL); > + if (prop) > + prom_remove_property(node, prop); > + > + flat_dt_start = virt_to_phys(initial_boot_params); > + flat_dt_end = virt_to_phys(initial_boot_params) > + + initial_boot_params->totalsize; > + prom_add_property(node, &flat_dt_start_prop); > + prom_add_property(node, &flat_dt_end_prop); You could use one property instead of two; use addr+len like every other property does. You also should use a better name for the property; is this the previous kernel's device tree? Just "device-tree" makes no sense, it is not pointing to "the" device tree for sure! Segher