From: Grant Erickson <gerickson@nuovations.com>
To: <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, sr@denx.de, jgarzik@pobox.com
Subject: Re: [PATCH] ibm_newemac: Add MII mode support to the EMAC RGMII bridge.
Date: Mon, 07 Jul 2008 16:47:53 -0700 [thread overview]
Message-ID: <C497F939.104DB%gerickson@nuovations.com> (raw)
In-Reply-To: <1215474042.8970.171.camel@pasglop>
On 7/7/08 4:40 PM, Benjamin Herrenschmidt wrote:
> On Mon, 2008-07-07 at 16:31 -0700, Grant Erickson wrote:
>> #define RGMII_FER_GMII(idx) (0x7 << ((idx) * 4))
>> +#define RGMII_FER_MII(idx) (0x7 << ((idx) * 4))
>
> Hrm... the setting of the register is exactly the same right ?
>
> Do we -really- need that ?
Would you prefer?
+#define RGMII_FER_MII(idx) RGMII_FER_GMII(idx)
Having the "extra" mnemonic makes the code end up looking less like a typo
and more like a conscious decision: "Yes, we know MII and GMII are the same
setting, but we're being explicit about it."
-Grant
next prev parent reply other threads:[~2008-07-07 23:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 23:31 [PATCH] ibm_newemac: Add MII mode support to the EMAC RGMII bridge Grant Erickson
2008-07-07 23:40 ` Benjamin Herrenschmidt
2008-07-07 23:47 ` Grant Erickson [this message]
2008-07-08 0:46 ` Benjamin Herrenschmidt
2008-07-08 15:03 ` [PATCH v2] " Grant Erickson
2008-07-08 15:35 ` Stefan Roese
2008-07-09 3:23 ` Benjamin Herrenschmidt
2008-07-11 5:19 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C497F939.104DB%gerickson@nuovations.com \
--to=gerickson@nuovations.com \
--cc=benh@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).