From: Grant Erickson <gerickson@nuovations.com>
To: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Cc: Stefan Roese <sr@denx.de>
Subject: PPC4xx ECC Configs, Defines and Source
Date: Mon, 08 Dec 2008 11:28:15 -0800 [thread overview]
Message-ID: <C562B54F.1351E%gerickson@nuovations.com> (raw)
Does anyone have any strong preferences on where configurations, definitions
and sources for a PPC4xx ECC monitoring and reporting driver should go?
Specifically, this concerns ECC handling code for the IBM DDR2 ECC
controller found in the 405EX[r], 440SP, 440SPe, 460EX and 460GT. However,
I'd like to do this in a way that other ECC contributors and maintainers can
build on.
Static Configs
--------------
I thought I might leverage the definitions Stefan Roese came up with for
u-boot for the base memory controller:
CONFIG_PPC4xx_IBM_SDRAM: Applicable to 405GP, 405CR, 405EP, AP1000,
and ML2
CONFIG_PPC4xx_IBM_DDR: Applicable to 440GP, 440GX, 440EP, and 440GR
CONFIG_PPC4xx_DENALI_DDR2: Applicable to 440EPX and 440GRX
CONFIG_PPC4xx_IBM_DDR2: Applicable to 405EX[r], 440SP, 440SPe, 460EX
and 460GT.
Controlling whether ECC monitoring and reporting support should be compiled
in or a module:
CONFIG_PPC_ECC or CONFIG_ECC
Dynamic Configs
---------------
It seems as though the DTS entries for SDRAM0: sdram { compatible = "..." }
would need to be expanded to include the above information as well were any
such ECC driver going to attempt to bind to the runtime DTS information.
Perhaps:
compatible = "...", "ibm,sdram-4xx-sdram";
compatible = "...", "ibm,sdram-4xx-ddr";
compatible = "...", "ibm,sdram-4xx-ddr2";
compatible = "...", "denali,sdram-4xx-ddr2";
Though, it appears that rainier.dts and sequioia.dts are already evolving in
this direction with:
compatible = "ibm,sdram-440grx", "ibm,sdram-44x-ddr2denali";
compatible = "ibm,sdram-440epx", "ibm,sdram-44x-ddr2denali";
In light of that, perhaps then:
compatible = "...", "ibm,sdram-4xx";
compatible = "...", "ibm,sdram-4xx-ddr";
compatible = "...", "ibm,sdram-4xx-ddr2";
compatible = "...", "ibm,sdram-4xx-ddr2denali";
Source
------
arch/powerpc/sysdev/
ppc4xx_ibm_sdram_ecc.c [future]
ppc4xx_ibm_ddr_ecc.c [future]
ppc4xx_ibm_ddr2_ecc.c
ppc4xx_ibm_ddr2denali_ecc.c [future]
Headers and Defines
-------------------
arch/powerpc/include/asm/ppc4xx_ibm_ddr2.h
OR
arch/powerpc/sysdev/ppc4xx_ibm_ddr2.h
Thoughts? Comments?
Regards,
Grant
next reply other threads:[~2008-12-08 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 19:28 Grant Erickson [this message]
2008-12-08 20:21 ` PPC4xx ECC Configs, Defines and Source Josh Boyer
2008-12-08 22:08 ` Grant Erickson
2008-12-08 23:10 ` Josh Boyer
2008-12-08 23:40 ` Grant Erickson
2008-12-09 5:57 ` Stefan Roese
2008-12-09 6:32 ` Grant Erickson
2008-12-10 8:53 ` Benjamin Herrenschmidt
2008-12-10 9:07 ` Stefan Roese
2008-12-10 12:37 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C562B54F.1351E%gerickson@nuovations.com \
--to=gerickson@nuovations.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).