linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, Timur Tabi <timur@freescale.com>
Subject: Re: [PATCH] [POWERPC] 86xx: mpc8610_hpcd: fix second serial port
Date: Mon, 12 May 2008 10:39:55 -0500	[thread overview]
Message-ID: <C8A812D2-0B23-4C5E-BA0F-0AD2BB295CF8@kernel.crashing.org> (raw)
In-Reply-To: <20080512123533.GA29838@polina.dev.rtsoft.ru>


On May 12, 2008, at 7:35 AM, Anton Vorontsov wrote:

> DIU platform code should not just write to the PIXIS' BRDCFG0  
> register,
> it should set and clear its own bits only, otherwise it will break
> firmware setup (in fact it breaks second uart).
>
> Also get rid of magic numbers in the related code.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/platforms/86xx/mpc8610_hpcd.c |   14 ++++++++++++--
> 1 files changed, 12 insertions(+), 2 deletions(-)

applied.

- k

      reply	other threads:[~2008-05-12 15:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 12:35 [PATCH] [POWERPC] 86xx: mpc8610_hpcd: fix second serial port Anton Vorontsov
2008-05-12 15:39 ` Kumar Gala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C8A812D2-0B23-4C5E-BA0F-0AD2BB295CF8@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).