From: Linus Torvalds <torvalds@linux-foundation.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] random: Fix crashes with sparse node ids
Date: Sat, 30 Jul 2016 20:56:09 -0700 [thread overview]
Message-ID: <CA+55aFyi9JyFMArYtv_QBRMkp4GjHzmrDA99VrksShR=LwgdWw@mail.gmail.com> (raw)
In-Reply-To: <87y44io5be.fsf@concordia.ellerman.id.au>
On Sat, Jul 30, 2016 at 8:27 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Dropping NOFAIL means we need to handle allocation failures, which makes
> the patch a bit bigger, and less of a pure fix.
Hmm. If you get allocation failures for something like this at init
time, I think you're basically screwed anyway.
And I really only meant for the initial array allocation, and the
__GFP_ZERO thing.
Yes, __GFP_ZERO does work for kmalloc() too, but unlike the other GPF
flags, we do have special zalloc versions for zeroing that are
generally preferred.
Linus
prev parent reply other threads:[~2016-07-31 3:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 14:23 [PATCH] random: Fix crashes with sparse node ids Michael Ellerman
2016-07-30 20:27 ` Linus Torvalds
2016-07-31 3:27 ` Michael Ellerman
2016-07-31 3:56 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFyi9JyFMArYtv_QBRMkp4GjHzmrDA99VrksShR=LwgdWw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).