From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ve0-x233.google.com (mail-ve0-x233.google.com [IPv6:2607:f8b0:400c:c01::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 7C4CE2C0092 for ; Tue, 6 Aug 2013 02:48:43 +1000 (EST) Received: by mail-ve0-f179.google.com with SMTP id c13so3353311vea.38 for ; Mon, 05 Aug 2013 09:48:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20130715164844.1520.27771.stgit@aruna-ThinkPad-T420> <51FA3B02.7060004@linux.vnet.ibm.com> <3908561D78D1C84285E8C5FCA982C28F31CAA167@ORSMSX106.amr.corp.intel.com> Date: Mon, 5 Aug 2013 09:41:16 -0700 Message-ID: Subject: Re: [PATCH 00/11] Add compression support to pstore From: Tony Luck To: Aruna Balakrishnaiah , "linuxppc-dev@ozlabs.org" , "paulus@samba.org" , "linux-kernel@vger.kernel.org" , "benh@kernel.crashing.org" , "keescook@chromium.org" Content-Type: text/plain; charset=ISO-8859-1 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , One more experiment - removed previous hack that disabled compression. Added a new hack to skip decompression. System died cleanly when I forced a panic. On reboot I found 3 files in pstore: -r--r--r-- 1 root root 3972 Aug 5 09:24 dmesg-erst-5908671953186586625 -r--r--r-- 1 root root 2565 Aug 5 09:24 dmesg-erst-5908671953186586626 -r--r--r-- 1 root root 4067 Aug 5 09:24 dmesg-erst-5908671953186586627 Using "openssl zlib -d" to decompress then ends up with some garbage at the end of the decompressed file - some text that should be there is missing. E.g. the tail of decompressed version of *625 ends with: <4>Call Trace: <4> [] dump_stack+0x45/0x56 <4> [] panic+0xc2/0x1cb <4> [] ? printk+0x54/0x56 <4> [] aegl+0x25/0x30 <4> [] proc_reg_write+0x3d/0x80 <4> [] vfs_write+0xc5/0x1e0 <4> [] SyS_write+0x52/0xa0 <4> [] system_call_fastpath+0x16/0x1b )c10^@^@^@^@^@^@^@^@^@ But my serial console logged this: Call Trace: [] dump_stack+0x45/0x56 [] panic+0xc2/0x1cb [] ? printk+0x54/0x56 [] aegl+0x25/0x30 [] proc_reg_write+0x3d/0x80 [] vfs_write+0xc5/0x1e0 [] SyS_write+0x52/0xa0 [] system_call_fastpath+0x16/0x1b ------------[ cut here ]------------ WARNING: CPU: 18 PID: 381 at arch/x86/kernel/smp.c:124 native_smp_send_reschedule+0x5b/0x60() Modules linked in: CPU: 18 PID: 381 Comm: kworker/18:1 Not tainted 3.11.0-rc3-11-ge41db9e #6 -Tony