Re: [PATCH 5.4 00/52] 5.4.153-rc2 review

Re: [PATCH 5.4 00/52] 5.4.153-rc2 review

[Naresh Kamboju]

On Tue, 12 Oct 2021 at 12:16, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.4.153 release.
> There are 52 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 14 Oct 2021 06:44:25 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.153-rc2.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

stable rc 5.4.153-rc2 Powerpc build failed.

In file included from arch/powerpc/net/bpf_jit64.h:11,
                 from arch/powerpc/net/bpf_jit_comp64.c:19:
arch/powerpc/net/bpf_jit_comp64.c: In function 'bpf_jit_build_body':
arch/powerpc/net/bpf_jit.h:32:9: error: expected expression before 'do'
   32 |         do { if (d) { (d)[idx] = instr; } idx++; } while (0)
      |         ^~
arch/powerpc/net/bpf_jit.h:33:33: note: in expansion of macro 'PLANT_INSTR'
   33 | #define EMIT(instr)             PLANT_INSTR(image, ctx->idx, instr)
      |                                 ^~~~~~~~~~~
arch/powerpc/net/bpf_jit_comp64.c:415:41: note: in expansion of macro 'EMIT'
  415 |                                         EMIT(PPC_LI(dst_reg, 0));
      |                                         ^~~~
arch/powerpc/net/bpf_jit.h:33:33: note: in expansion of macro 'PLANT_INSTR'
   33 | #define EMIT(instr)             PLANT_INSTR(image, ctx->idx, instr)
      |                                 ^~~~~~~~~~~
arch/powerpc/net/bpf_jit.h:41:33: note: in expansion of macro 'EMIT'
   41 | #define PPC_ADDI(d, a, i)       EMIT(PPC_INST_ADDI |
___PPC_RT(d) |           \
      |                                 ^~~~
arch/powerpc/net/bpf_jit.h:44:33: note: in expansion of macro 'PPC_ADDI'
   44 | #define PPC_LI(r, i)            PPC_ADDI(r, 0, i)
      |                                 ^~~~~~~~
arch/powerpc/net/bpf_jit_comp64.c:415:46: note: in expansion of macro 'PPC_LI'
  415 |                                         EMIT(PPC_LI(dst_reg, 0));
      |                                              ^~~~~~
make[3]: *** [scripts/Makefile.build:262:
arch/powerpc/net/bpf_jit_comp64.o] Error 1
make[3]: Target '__build' not remade because of errors.

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

-- 
Linaro LKFT
https://lkft.linaro.org

Re: [PATCH 5.4 00/52] 5.4.153-rc2 review

[Greg Kroah-Hartman]

On Tue, Oct 12, 2021 at 01:04:54PM +0530, Naresh Kamboju wrote:
> On Tue, 12 Oct 2021 at 12:16, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 5.4.153 release.
> > There are 52 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 14 Oct 2021 06:44:25 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.153-rc2.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> 
> stable rc 5.4.153-rc2 Powerpc build failed.
> 
> In file included from arch/powerpc/net/bpf_jit64.h:11,
>                  from arch/powerpc/net/bpf_jit_comp64.c:19:
> arch/powerpc/net/bpf_jit_comp64.c: In function 'bpf_jit_build_body':
> arch/powerpc/net/bpf_jit.h:32:9: error: expected expression before 'do'
>    32 |         do { if (d) { (d)[idx] = instr; } idx++; } while (0)
>       |         ^~
> arch/powerpc/net/bpf_jit.h:33:33: note: in expansion of macro 'PLANT_INSTR'
>    33 | #define EMIT(instr)             PLANT_INSTR(image, ctx->idx, instr)
>       |                                 ^~~~~~~~~~~
> arch/powerpc/net/bpf_jit_comp64.c:415:41: note: in expansion of macro 'EMIT'
>   415 |                                         EMIT(PPC_LI(dst_reg, 0));
>       |                                         ^~~~
> arch/powerpc/net/bpf_jit.h:33:33: note: in expansion of macro 'PLANT_INSTR'
>    33 | #define EMIT(instr)             PLANT_INSTR(image, ctx->idx, instr)
>       |                                 ^~~~~~~~~~~
> arch/powerpc/net/bpf_jit.h:41:33: note: in expansion of macro 'EMIT'
>    41 | #define PPC_ADDI(d, a, i)       EMIT(PPC_INST_ADDI |
> ___PPC_RT(d) |           \
>       |                                 ^~~~
> arch/powerpc/net/bpf_jit.h:44:33: note: in expansion of macro 'PPC_ADDI'
>    44 | #define PPC_LI(r, i)            PPC_ADDI(r, 0, i)
>       |                                 ^~~~~~~~
> arch/powerpc/net/bpf_jit_comp64.c:415:46: note: in expansion of macro 'PPC_LI'
>   415 |                                         EMIT(PPC_LI(dst_reg, 0));
>       |                                              ^~~~~~
> make[3]: *** [scripts/Makefile.build:262:
> arch/powerpc/net/bpf_jit_comp64.o] Error 1
> make[3]: Target '__build' not remade because of errors.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

Ok, I'm just going to go delete this patch from the queue now...

Thanks for the quick report.

greg k-h