linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: nicoleotsuka@gmail.com, alsa-devel@alsa-project.org,
	lgirdwood@gmail.com, Jacopo Mondi <jacopo@jmondi.org>,
	Xiubo.Lee@gmail.com, Takashi Iwai <tiwai@suse.de>,
	linux-kernel@vger.kernel.org,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	tiwai@suse.com, linux-media@vger.kernel.org, tfiga@chromium.org,
	Hans Verkuil <hverkuil@xs4all.nl>,
	linuxppc-dev@lists.ozlabs.org, Sakari Ailus <sakari.ailus@iki.fi>,
	perex@perex.cz, mchehab@kernel.org, festevam@gmail.com,
	m.szyprowski@samsung.com
Subject: Re: [PATCH 1/6] media: v4l2: Add audio capture and output support
Date: Fri, 7 Jul 2023 11:13:43 +0800	[thread overview]
Message-ID: <CAA+D8AMNqU0J1EC--BBVYbXMf1dRGdS-ez5hs2E8M_hYtwq60w@mail.gmail.com> (raw)
In-Reply-To: <CAA+D8AMTnZb-Sm9gh_jDDSz3y9jXY-mD9S6vXPekAbdfCJaKHA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2147 bytes --]

Hi Mark

On Tue, Jul 4, 2023 at 12:03 PM Shengjiu Wang <shengjiu.wang@gmail.com>
wrote:

>
>
> On Tue, Jul 4, 2023 at 1:59 AM Mark Brown <broonie@kernel.org> wrote:
>
>> On Mon, Jul 03, 2023 at 03:12:55PM +0200, Hans Verkuil wrote:
>>
>> > My main concern is that these cross-subsystem drivers are a pain to
>> > maintain. So there have to be good reasons to do this.
>>
>> > Also it is kind of weird to have to use the V4L2 API in userspace to
>> > deal with a specific audio conversion. Quite unexpected.
>>
>> > But in the end, that's a decision I can't make.
>>
>> > So I wait for that feedback. Note that if the decision is made that this
>> > can use V4L2, then there is quite a lot more that needs to be done:
>> > documentation, new compliance tests, etc. It's adding a new API, and
>> that
>> > comes with additional work...
>>
>> Absolutely, I agree with all of this - my impression was that the target
>> here would be bypass of audio streams to/from a v4l2 device, without
>> bouncing through an application layer.  If it's purely for audio usage
>> with no other tie to v4l2 then involving v4l2 does just seem like
>> complication.
>>
>
> This audio use case is using the v4l2 application layer. in the user space
> I need to call below v4l2 ioctls to implement the feature:
> VIDIOC_QUERYCAP
> VIDIOC_TRY_FMT
> VIDIOC_S_FMT
> VIDIOC_REQBUFS
> VIDIOC_QUERYBUF
> VIDIOC_STREAMON
> VIDIOC_QBUF
> VIDIOC_DQBUF
> VIDIOC_STREAMOFF
>
> why the driver was put in the ALSA, because previously we implemented
> the ASRC M2P (memory to peripheral) in ALSA,  so I think it is better to
> add M2M driver in ALSA.  The hardware IP is the same. The compatible
> string is the same.
>
>
> Could you please share more of your ideas about this patch? and could
you please check further about this implementation.

I tried to find a good interface in ALSA for this m2m request, but didn't
find one,  then I try the V4L2, find it is good this audio case.

but it needs to extend the V4L2 API.

I have no idea how to go on, could you please recommend?

best regards
wang shengjiu

>
>

[-- Attachment #2: Type: text/html, Size: 3336 bytes --]

  reply	other threads:[~2023-07-07 11:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29  1:37 [PATCH 0/6] Add audio support in v4l2 framework Shengjiu Wang
2023-06-29  1:37 ` [PATCH 1/6] media: v4l2: Add audio capture and output support Shengjiu Wang
2023-06-30 10:05   ` Sakari Ailus
2023-07-03  9:54     ` Shengjiu Wang
2023-07-03 10:04       ` Hans Verkuil
2023-07-03 12:07       ` Takashi Iwai
2023-07-03 12:53         ` Mark Brown
2023-07-03 13:12           ` Hans Verkuil
2023-07-03 13:25             ` Takashi Iwai
2023-07-04  3:55               ` Shengjiu Wang
2023-07-03 17:58             ` Mark Brown
2023-07-04  4:03               ` Shengjiu Wang
2023-07-07  3:13                 ` Shengjiu Wang [this message]
2023-07-19  9:15                   ` Shengjiu Wang
2023-06-29  1:37 ` [PATCH 2/6] ASoC: fsl_asrc: define functions for memory to memory usage Shengjiu Wang
2023-06-29  1:37 ` [PATCH 3/6] ASoC: fsl_easrc: " Shengjiu Wang
2023-06-29 10:59   ` Fabio Estevam
2023-06-30  3:23     ` Shengjiu Wang
2023-06-29  1:37 ` [PATCH 4/6] ASoC: fsl_asrc: Add memory to memory driver Shengjiu Wang
2023-06-29 11:38   ` Mark Brown
2023-06-30  3:37     ` Shengjiu Wang
2023-06-30 11:22       ` Mark Brown
2023-06-29  1:37 ` [PATCH 5/6] ASoC: fsl_asrc: enable memory to memory function Shengjiu Wang
2023-06-29  1:37 ` [PATCH 6/6] ASoC: fsl_easrc: " Shengjiu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA+D8AMNqU0J1EC--BBVYbXMf1dRGdS-ez5hs2E8M_hYtwq60w@mail.gmail.com \
    --to=shengjiu.wang@gmail.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jacopo@jmondi.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@kernel.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=perex@perex.cz \
    --cc=sakari.ailus@iki.fi \
    --cc=shengjiu.wang@nxp.com \
    --cc=tfiga@chromium.org \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).