* [PATCH] ASoC: imx-audmux: remove unnecessary check of clk_disable_unprepare
@ 2022-06-02 7:14 cgel.zte
2022-06-06 2:05 ` Shengjiu Wang
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-06-02 7:14 UTC (permalink / raw)
To: shengjiu.wang
Cc: alsa-devel, linux-kernel, Xiubo.Lee, linuxppc-dev, Zeal Robot,
lgirdwood, Minghao Chi, perex, nicoleotsuka, broonie, festevam,
linux-arm-kernel
From: Minghao Chi <chi.minghao@zte.com.cn>
Because clk_disable_unprepare already checked NULL clock
parameter, so the additional checks are unnecessary, just remove them.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
sound/soc/fsl/imx-audmux.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
index dfa05d40b276..f434fa7decc1 100644
--- a/sound/soc/fsl/imx-audmux.c
+++ b/sound/soc/fsl/imx-audmux.c
@@ -71,8 +71,7 @@ static ssize_t audmux_read_file(struct file *file, char __user *user_buf,
ptcr = readl(audmux_base + IMX_AUDMUX_V2_PTCR(port));
pdcr = readl(audmux_base + IMX_AUDMUX_V2_PDCR(port));
- if (audmux_clk)
- clk_disable_unprepare(audmux_clk);
+ clk_disable_unprepare(audmux_clk);
buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
if (!buf)
@@ -218,8 +217,7 @@ int imx_audmux_v2_configure_port(unsigned int port, unsigned int ptcr,
writel(ptcr, audmux_base + IMX_AUDMUX_V2_PTCR(port));
writel(pdcr, audmux_base + IMX_AUDMUX_V2_PDCR(port));
- if (audmux_clk)
- clk_disable_unprepare(audmux_clk);
+ clk_disable_unprepare(audmux_clk);
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: imx-audmux: remove unnecessary check of clk_disable_unprepare
2022-06-02 7:14 [PATCH] ASoC: imx-audmux: remove unnecessary check of clk_disable_unprepare cgel.zte
@ 2022-06-06 2:05 ` Shengjiu Wang
0 siblings, 0 replies; 2+ messages in thread
From: Shengjiu Wang @ 2022-06-06 2:05 UTC (permalink / raw)
To: cgel.zte
Cc: alsa-devel, linux-kernel, Xiubo Li, linuxppc-dev, Zeal Robot,
Liam Girdwood, Minghao Chi, Jaroslav Kysela, Nicolin Chen,
Mark Brown, Fabio Estevam,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]
On Thu, Jun 2, 2022 at 3:14 PM <cgel.zte@gmail.com> wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Because clk_disable_unprepare already checked NULL clock
> parameter, so the additional checks are unnecessary, just remove them.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> sound/soc/fsl/imx-audmux.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
> index dfa05d40b276..f434fa7decc1 100644
> --- a/sound/soc/fsl/imx-audmux.c
> +++ b/sound/soc/fsl/imx-audmux.c
> @@ -71,8 +71,7 @@ static ssize_t audmux_read_file(struct file *file, char
> __user *user_buf,
> ptcr = readl(audmux_base + IMX_AUDMUX_V2_PTCR(port));
> pdcr = readl(audmux_base + IMX_AUDMUX_V2_PDCR(port));
>
> - if (audmux_clk)
> - clk_disable_unprepare(audmux_clk);
> + clk_disable_unprepare(audmux_clk);
>
I think the check of audmux_clk before "clk_prepare_enable" also
can be removed?
> buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
> if (!buf)
> @@ -218,8 +217,7 @@ int imx_audmux_v2_configure_port(unsigned int port,
> unsigned int ptcr,
> writel(ptcr, audmux_base + IMX_AUDMUX_V2_PTCR(port));
> writel(pdcr, audmux_base + IMX_AUDMUX_V2_PDCR(port));
>
> - if (audmux_clk)
> - clk_disable_unprepare(audmux_clk);
> + clk_disable_unprepare(audmux_clk);
>
ditto
best regards
wang shengjiu
>
> return 0;
> }
> --
> 2.25.1
>
>
>
[-- Attachment #2: Type: text/html, Size: 2656 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-06 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-02 7:14 [PATCH] ASoC: imx-audmux: remove unnecessary check of clk_disable_unprepare cgel.zte
2022-06-06 2:05 ` Shengjiu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).