Re: [PATCH] ASoC: fsl_asrc: Add initialization finishing check in runtime resume

[Shengjiu Wang <shengjiu.wang@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

On Tue, Sep 6, 2022 at 7:42 PM Nicolin Chen <nicoleotsuka@gmail.com> wrote:

> On Tue, Sep 6, 2022 at 3:50 AM Shengjiu Wang <shengjiu.wang@gmail.com>
> wrote:
> >> >> > +       /* Wait for status of initialization for every enabled
> pairs */
> >> >> > +       do {
> >> >> > +               udelay(5);
> >> >> > +               regmap_read(asrc->regmap, REG_ASRCFG, &reg);
> >> >> > +               reg = (reg >> ASRCFG_INIRQi_SHIFT(0)) & 0x7;
> >> >> > +       } while ((reg != ((asrctr >> ASRCTR_ASRCEi_SHIFT(0)) &
> 0x7)) && --retry);
> >> >> > +
> >> >> > +       /* FIXME: Doesn't treat initialization timeout as error */
> >> >> > +       if (!retry)
> >> >> > +               dev_warn(dev, "initialization isn't finished\n");
> >> >>
> >> >> Any reason why not just dev_err?
> >> >
> >> > Just hesitate to use dev_err. if use dev_err, then should return an
> error.
> >> > May one of the pairs is finished, it still can continue.
> >>
> >> Makes sense. In that case, why "FIXME" :)
>
> > Just want to have a record/note here, need to care about this warning.
>
> "FIXME" feels like something is wrong and literally means that it is
> waiting for a fix/solution. In your case, it's not waiting for a fix
> at all, but just an annotation? So, shouldn't it be just "Note:"?
>

ok, let me update it.

best regards
wang shengjiu

[-- Attachment #2: Type: text/html, Size: 2189 bytes --]