From: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: nicoleotsuka@gmail.com, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, Xiubo.Lee@gmail.com,
linux-kernel@vger.kernel.org,
Shengjiu Wang <shengjiu.wang@nxp.com>,
tiwai@suse.com, linux-media@vger.kernel.org, tfiga@chromium.org,
hverkuil@xs4all.nl, linuxppc-dev@lists.ozlabs.org,
sakari.ailus@iki.fi, perex@perex.cz, mchehab@kernel.org,
festevam@gmail.com, m.szyprowski@samsung.com
Subject: Re: [RFC PATCH v5 01/11] ASoC: fsl_asrc: define functions for memory to memory usage
Date: Sun, 8 Oct 2023 11:30:38 +0800 [thread overview]
Message-ID: <CAA+D8AOyDD9Wd0pHFW=jwY9FKqY0OA2UMmDRrB_UnSPN4FJSZA@mail.gmail.com> (raw)
In-Reply-To: <7af54654-d4d5-498e-bd53-78ad54e6d818@sirena.org.uk>
Hi
On Mon, Oct 2, 2023 at 11:08 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Sep 28, 2023 at 05:00:09PM +0800, Shengjiu Wang wrote:
>
> > m2m_start_part_one: first part of the start steps
> > m2m_start_part_two: second part of the start steps
> > m2m_stop_part_one: first part of stop steps
> > m2m_stop_part_two: second part of stop steps, optional
>
> The part_one/two naming isn't amazing here. Looking at the rest of the
> code it looks like this is a prepare/trigger type distinction where the
> first part is configuring things prior to DMA setup and the second part
> is actually starting the transfer. Perhaps _config()/_start() instead?
Ok, I will use m2m_prepare/m2m_unprepare to replace
m2m_start_part_one/m2m_stop_part_one, and use m2m_start/m2m_stop
to replace m2m_start_part_two/m2m_stop_part_two.
Best regards
Wang shengjiu
next prev parent reply other threads:[~2023-10-08 3:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 9:00 [RFC PATCH v5 00/11] Add audio support in v4l2 framework Shengjiu Wang
2023-09-28 9:00 ` [RFC PATCH v5 01/11] ASoC: fsl_asrc: define functions for memory to memory usage Shengjiu Wang
2023-10-02 15:07 ` Mark Brown
2023-10-08 3:30 ` Shengjiu Wang [this message]
2023-09-28 9:00 ` [RFC PATCH v5 02/11] ASoC: fsl_easrc: " Shengjiu Wang
2023-09-28 9:00 ` [RFC PATCH v5 03/11] ASoC: fsl_asrc: move fsl_asrc_common.h to include/sound Shengjiu Wang
2023-09-28 9:00 ` [RFC PATCH v5 04/11] ASoC: fsl_asrc: register m2m platform device Shengjiu Wang
2023-09-28 9:00 ` [RFC PATCH v5 05/11] ASoC: fsl_easrc: " Shengjiu Wang
2023-09-28 9:00 ` [RFC PATCH v5 06/11] media: uapi: Add V4L2_CAP_AUDIO_M2M capability flag Shengjiu Wang
2023-09-28 9:00 ` [RFC PATCH v5 07/11] media: v4l2: Add audio capture and output support Shengjiu Wang
2023-10-09 14:20 ` Hans Verkuil
2023-09-28 9:00 ` [RFC PATCH v5 08/11] media: uapi: Add audio rate controls support Shengjiu Wang
2023-10-09 14:33 ` Hans Verkuil
2023-09-28 9:00 ` [RFC PATCH v5 09/11] media: uapi: define audio sample format fourcc type Shengjiu Wang
2023-10-09 14:44 ` Hans Verkuil
2023-09-28 9:00 ` [RFC PATCH v5 10/11] media: imx-asrc: Add memory to memory driver Shengjiu Wang
2023-09-28 9:00 ` [RFC PATCH v5 11/11] media: audm2m: add virtual driver for audio memory to memory Shengjiu Wang
2023-10-09 15:11 ` Hans Verkuil
2023-10-02 15:10 ` [RFC PATCH v5 00/11] Add audio support in v4l2 framework Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA+D8AOyDD9Wd0pHFW=jwY9FKqY0OA2UMmDRrB_UnSPN4FJSZA@mail.gmail.com' \
--to=shengjiu.wang@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=sakari.ailus@iki.fi \
--cc=shengjiu.wang@nxp.com \
--cc=tfiga@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).