From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30111C433F5 for ; Mon, 9 May 2022 01:13:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KxNTp1G9zz3cCk for ; Mon, 9 May 2022 11:13:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=gIUFYKCQ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::830; helo=mail-qt1-x830.google.com; envelope-from=shengjiu.wang@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=gIUFYKCQ; dkim-atps=neutral Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KwxWw6Rjqz2xF8 for ; Sun, 8 May 2022 17:58:51 +1000 (AEST) Received: by mail-qt1-x830.google.com with SMTP id y3so9015379qtn.8 for ; Sun, 08 May 2022 00:58:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rZVhWVA+EdiAZkxXcgq5S21iMUVQBopURuPfX+xp/uQ=; b=gIUFYKCQeN/B58sPwgdDuch1cOCuxKNjSrwNzscjlympP+cuTuAqg6INyjeEzu+6IS bRycio946YWHG+w+7Bp5XrUWI2XN1IT4YCifS0wpudFLVHnWZFbp/lHFggVF2vttzAqH xlUhPfrdJjGLwLADAOT7Co+88F8jg4wQnE1Eh3xFTP+KNJRC9ZGFP6d7UptIvt96K3Hf HlEh/D7PObgDVhcwbmltRjJWQa7aIesVj/38/0J94Vt5Nf/WlPHKGoElLqw+Tw2n/ltE uAuJJ8ALz0zU/hHVjOevEy83NwQyIRC22RwP9odiQgljHRxq8Jsy0GNFcg8sSvpfZcVz kThA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rZVhWVA+EdiAZkxXcgq5S21iMUVQBopURuPfX+xp/uQ=; b=p+tw3+sINpnIQ+ri9v8pc8hpkaGDubCBqXVZ9/VygO4nAOY6kohM3hYlCq1YfqCgio savw1l4I9iq7aAYWftrPJMzdhoHiYFIihOcqwZvEoZbFIYHzJ51rh+uOyIHKfTPkvfZC D+/9d6B8uQLtgQCzNKlx4katxlwkd5WvnBKoGd+a/R82sNW6yJvnDDskztvxVnWJxBuE 6PUpJsijfADnjEK+8IAXaThVFt6ofucVCnM7WyhqyIsjFUKakvCo0vSBcRISSNJbBikL sMr4FLHe155w8R83VUOkL8Fs2rmvMNobRF2eieJt1XTg7EO6lw7waoa++yUvqAS9tNzw F9Rw== X-Gm-Message-State: AOAM531u7jCIZI9J0YEVirljHCHMNI1o6DgOMtmJiXNsD+gcAtE0Ij4L fICUKuQ5czsR3bmZlY+4/k++8v6xnIsfoxQJpKE= X-Google-Smtp-Source: ABdhPJyNd2eXVDqLQaJ2XSfZasJbZg++pVfPsBuzCeYRWHOHlaLxUTCqb6BQaZtTG0xKbNsZQYf7XOr/kc7ZoH7vedI= X-Received: by 2002:ac8:5ad1:0:b0:2f3:cf42:b3bc with SMTP id d17-20020ac85ad1000000b002f3cf42b3bcmr5076602qtd.120.1651996726562; Sun, 08 May 2022 00:58:46 -0700 (PDT) MIME-Version: 1.0 References: <20220507123101.10938-1-pieterjan.camerlynck@gmail.com> In-Reply-To: <20220507123101.10938-1-pieterjan.camerlynck@gmail.com> From: Shengjiu Wang Date: Sun, 8 May 2022 15:58:35 +0800 Message-ID: Subject: Re: [PATCH] ASoC: fsl_sai: fix incorrect mclk number in error message To: Pieterjan Camerlynck Content-Type: multipart/alternative; boundary="0000000000000e930105de7b7641" X-Mailman-Approved-At: Mon, 09 May 2022 11:12:57 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linuxppc-dev , linux-kernel , Xiubo Li Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --0000000000000e930105de7b7641 Content-Type: text/plain; charset="UTF-8" On Sat, May 7, 2022 at 8:31 PM Pieterjan Camerlynck < pieterjan.camerlynck@gmail.com> wrote: > In commit ("ASoC: fsl_sai: add sai master mode support") > the loop was changed to start iterating from 1 instead of 0. The error > message however was not updated, reporting the wrong clock to the user. > > Signed-off-by: Pieterjan Camerlynck > Acked-by: Shengjiu Wang Best Regards Wang Shengjiu > --- > sound/soc/fsl/fsl_sai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c > index ffc24afb5a7a..f0602077b385 100644 > --- a/sound/soc/fsl/fsl_sai.c > +++ b/sound/soc/fsl/fsl_sai.c > @@ -1054,7 +1054,7 @@ static int fsl_sai_probe(struct platform_device > *pdev) > sai->mclk_clk[i] = devm_clk_get(&pdev->dev, tmp); > if (IS_ERR(sai->mclk_clk[i])) { > dev_err(&pdev->dev, "failed to get mclk%d clock: > %ld\n", > - i + 1, PTR_ERR(sai->mclk_clk[i])); > + i, PTR_ERR(sai->mclk_clk[i])); > sai->mclk_clk[i] = NULL; > } > } > -- > 2.25.1 > > --0000000000000e930105de7b7641 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sat, May 7, 2022 at 8:31 PM Pieter= jan Camerlynck <pieter= jan.camerlynck@gmail.com> wrote:
In commit <c3ecef21c3f26> ("ASoC: fsl_sa= i: add sai master mode support")
the loop was changed to start iterating from 1 instead of 0. The error
message however was not updated, reporting the wrong clock to the user.

Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
=

Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>

=
Best Regards
Wang Shengjiu=C2=A0
---
=C2=A0sound/soc/fsl/fsl_sai.c | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index ffc24afb5a7a..f0602077b385 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -1054,7 +1054,7 @@ static int fsl_sai_probe(struct platform_device *pdev= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 sai->mclk_clk[i]= =3D devm_clk_get(&pdev->dev, tmp);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (IS_ERR(sai->= mclk_clk[i])) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 dev_err(&pdev->dev, "failed to get mclk%d clock: %ld= \n",
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0i + 1, PT= R_ERR(sai->mclk_clk[i]));
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0i, PTR_ER= R(sai->mclk_clk[i]));
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 sai->mclk_clk[i] =3D NULL;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
--
2.25.1

--0000000000000e930105de7b7641--